Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interval describing shifting quantities #57

Open
Aazhar opened this issue Feb 19, 2018 · 1 comment
Open

Interval describing shifting quantities #57

Aazhar opened this issue Feb 19, 2018 · 1 comment

Comments

@Aazhar
Copy link
Collaborator

Aazhar commented Feb 19, 2018

reversed intervals are not extracted in the right way as quantity least/most values.
example taken from hal-00924047 :

the emission maxima shifted from 345 nm to 325 nm

Gives this :

"measurements": [

    {
        "type": "interval",
        "quantityLeast": {
            "type": "length",
            "rawValue": "345",
            "rawUnit": {
                "name": "nm",
                "offsetStart": 47,
                "offsetEnd": 49
            },
            "parsedValue": 345,
            "normalizedQuantity": 3.45e-7,
            "normalizedUnit": {
                "name": "m",
                "type": "length",
                "system": "SI base"
            },
            "offsetStart": 33,
            "offsetEnd": 36,
            "quantified": {
                "rawName": "nm",
                "normalizedName": "nm",
                "offsetStart": 37,
                "offsetEnd": 39
            }
        },
        "quantityMost": {
            "type": "length",
            "rawValue": "325",
            "rawUnit": {
                "name": "nm",
                "offsetStart": 47,
                "offsetEnd": 49
            },
            "parsedValue": 325,
            "normalizedQuantity": 3.25e-7,
            "normalizedUnit": {
                "name": "m",
                "type": "length",
                "system": "SI base"
            },
            "offsetStart": 43,
            "offsetEnd": 46,
            "quantified": {
                "rawName": "nm",
                "normalizedName": "nm",
                "offsetStart": 37,
                "offsetEnd": 39
            }
        },
        "quantified": {
            "rawName": "nm",
            "normalizedName": "nm",
            "offsetStart": 37,
            "offsetEnd": 39
        }
}
@lfoppiano
Copy link
Owner

lfoppiano commented Feb 28, 2018

Well in this case looks like the from->to is not expressing an interval but a behaviour?
We could add an additional check that the least is actually smaller than the most extreme. I'm wondering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants