Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new favicon #80

Open
Kevils opened this issue Dec 17, 2024 · 9 comments · May be fixed by #81
Open

Add new favicon #80

Kevils opened this issue Dec 17, 2024 · 9 comments · May be fixed by #81
Labels
Good first issue Good for newcomers OD Hack Issue reserved for the OD Hack Open for contribution An issue that is available for an Only Dust contribution

Comments

@Kevils
Copy link
Collaborator

Kevils commented Dec 17, 2024

Description 📹

Current favicon:
image

New favicon:
image

Available to download on this link : https://www.figma.com/design/S1UKYgWewNqNHZFAaBUilG/%F0%9F%8F%9D%EF%B8%8F-Starknet-ID?node-id=1565-7090&t=raVo3Ssk9Y16k7PM-1

Add new favicon

Proposed Actions 🛠️

Here’s a checklist of actions to follow for resolving this issue:

  1. Fork and Create Branch:
    Fork the repository and create a new branch using the issue number:

    git checkout -b fix-[issue-number]
  2. Implement Changes:
    [Insert Code snippet if needed with a mardown todo list]

  3. Run Tests and Commit Changes:
    Make sure your changes don't break existing functionality and commit with a clear message:

    git commit -m "Fix: [Short description of the fix]"

Required 📋

To keep our workflow smooth, please make sure you follow these guidelines:

  • Assignment: Don't create a pull request if you weren’t assigned to this issue.
  • Timeframe: Complete the task within 3 business days.
  • Closing the Issue: In your PR description, close the issue by writing Close #[issue_id].
  • Review Process:
    • Once you've submitted your PR, change the label to "ready for review".
    • If changes are requested, address them and then update the label back to "ready for review" once done.
  • Testing: Test your PR locally before pushing, and verify that tests and build are working after pushing.

Thank you for your contribution 🙏

⚠️ WARNING: Failure to follow the requirements above may result in being added to the OnlyDust blacklist, affecting your ability to receive future rewards.

@SudiptaPaul-31
Copy link

@Kevils Would love to work on this issue

@hossamanany hossamanany linked a pull request Dec 19, 2024 that will close this issue
@Kevils Kevils added OD Hack Issue reserved for the OD Hack Open for contribution An issue that is available for an Only Dust contribution Good first issue Good for newcomers labels Dec 23, 2024
@ekumamatthew
Copy link

Could I try solving this?

@michojekunle
Copy link

Could I grab this task?

My approach:

  • Replace the current favicon with the new one provided in the Figma link.
  • Ensure the favicon displays correctly across all major browsers.

ETA 3 HOURS.

Looking forward to your approval!

@davedumto
Copy link

Hi,
My name is David, and I am a frontend developer skilled in JavaScript, TypeScript, React.js, and Next.js. I will update the current favicon with the new design provided in the Figma file, ensuring no functionality is broken during the update. ETA 3hrs

@ryzen-xp
Copy link

I’m interested in this one.

@johnsmccain
Copy link

Can I try solving this issue?

@aniketch07
Copy link

Mind if I take this issue?

@3th-Enjay
Copy link

hello i a am nelson a frontend developer, and i can take this on as i have done something similar in the past

@Amarjeet325
Copy link

Can I try solving this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers OD Hack Issue reserved for the OD Hack Open for contribution An issue that is available for an Only Dust contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants