-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update get_quest_participants to return the timestamp of quest completion #358
Comments
can I work on this issue? |
Can I work on this issue? @Marchand-Nicolas |
I would love to do this, sir! |
Can I handle this? |
Can i work on this? How i will tackle this?
|
@Marchand-Nicolas can i make this my first contribution to the starkquest ecosystem, would be a nice one to have |
I'd like to take this issue. |
Hi, @Marchand-Nicolas |
Can I be assign to this , I will love to make this my first contribution to Starknet project |
@Marchand-Nicolas |
May I take this issue on? |
Can I contribute to this one? |
Would love to tackle this! |
Could I take over this issue? |
Hi @Marchand-Nicolas, can i take this issue? I’ll modify the endpoint to return the latest completed_task timestamp for each quest I am a full stack dev, trying to move forward, I'm a Dojo Coding member. I am learning rust and i think this is a good first issue for me, it'll help me grow. ETA = 12 hours |
Is this issue still available? |
I'm interested in working on this issue and would like to contribute to the project. Could you please assign it to me? Thank you! 😊 |
Let me try this one! |
Could I take a shot at this? |
Can I handle this, I think have the experience to handle this |
Can I try solving this issue? |
Can I be assigned on this ? |
Hello @TropicalDog17 is everything okay ? |
Hi, I will try to put up a draft PR today, sorry for the delay @Marchand-Nicolas |
No problem, just wanted to make sure everything was good |
Description 📹
Update
src/endpoints/admin/quest/get_quest_participants.rs
to return the timestamp of quest completion. The timestamp is the greatesttimestamp
among allcompleted_task
documents for the specified quest & address.Proposed Actions 🛠️
Here’s a checklist of actions to follow for resolving this issue:
Fork and Create Branch:
Fork the repository and create a new branch using the issue number:
Implement Changes:
get_quest_participants_handler
function to include logic for fetching the greatest timestamp for each participant.timestamp
for each participant who has completed all tasks in the quest.TODO List:
$max
stage in the aggregation pipeline to compute the maximum timestamp.completed_task
data.Example Code Snippet for Aggregation Update:
Run Tests and Commit Changes:
Make sure your changes don't break existing functionality and commit with a clear message:
git commit -m "Fix: Include quest completion timestamp in get_quest_participants response"
Required 📋
To keep our workflow smooth, please make sure you follow these guidelines:
Close #[issue_id]
.Thank you for your contribution 🙏
The text was updated successfully, but these errors were encountered: