Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release files for arm/aarch are not generated correctly #32

Closed
perklet opened this issue Jan 19, 2024 · 8 comments · Fixed by #38
Closed

Release files for arm/aarch are not generated correctly #32

perklet opened this issue Jan 19, 2024 · 8 comments · Fixed by #38

Comments

@perklet
Copy link
Collaborator

perklet commented Jan 19, 2024

Some bug must be introduced in v0.6.0b7...v0.6.0b8

@bjia56
Copy link
Collaborator

bjia56 commented Jan 19, 2024

What's the issue with the generated files? Might be related to the manylinux changes I made

@perklet
Copy link
Collaborator Author

perklet commented Jan 19, 2024

Some files are much smaller than before, I checked and the .so files are missing.

@bjia56
Copy link
Collaborator

bjia56 commented Jan 19, 2024

I can look into it as well

@bjia56
Copy link
Collaborator

bjia56 commented Jan 19, 2024

I recommend reverting #30 and #14 for now and see if the binaries build properly. Not sure why the arm/aarch64 emulated builds are dropping those binaries, I can reproduce it with a manual build inside the container.

@bjia56
Copy link
Collaborator

bjia56 commented Jan 21, 2024

Ok I see part of the issue - in x86_64, curl configuration reports this line:

2024-01-04T09:55:36.5448671Z   Build libcurl:    Shared=yes, Static=yes

whereas for arm:

2024-01-19T09:02:26.7690837Z   Build libcurl:    Shared=no, Static=yes

Testing a fix here: bjia56#3

@bjia56
Copy link
Collaborator

bjia56 commented Jan 22, 2024

For arm, the container is missing devtoolset-10-binutils. I'll need to build that from source.

@perklet
Copy link
Collaborator Author

perklet commented Jan 31, 2024

It seems that the libcurl files are correct now, but the curl binaries are still too small.

@bjia56
Copy link
Collaborator

bjia56 commented Jan 31, 2024

I can take another look at it in the next few days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants