You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently do tool version detection (asdf/mise/system) twice: once in bash when we boot the server, and once in Elixir when we boot the remote control node:
It's fine if we have to do this twice, but we should find a way to share code here. There was a reason I didn't do this immediately when I rewrote the bash side of things, but I don't recall what it was.
The text was updated successfully, but these errors were encountered:
This could then be passed Lexical.Server.Boot.start which could set Application.put_env(:server, :elixir_executable, elixir_executable) (or perhaps Application.put_env(:lexical, ...)?)
This app env var could then be read when starting the remote control node instead of going through elixir_executable/0
Doing this would, I think, guarantee that the remote control node always be started using the exact same Elixir executable that started the server. I also believe it would be more future-proof: while Lexical doesn't currently support Windows, this removes a code-path in RemoteControl that assumes a unix-like environment.
We currently do tool version detection (asdf/mise/system) twice: once in bash when we boot the server, and once in Elixir when we boot the remote control node:
lexical/apps/remote_control/lib/lexical/remote_control.ex
Line 128 in d441dd2
It's fine if we have to do this twice, but we should find a way to share code here. There was a reason I didn't do this immediately when I rewrote the bash side of things, but I don't recall what it was.
The text was updated successfully, but these errors were encountered: