Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Converters] Add toStringNoZero() function #4765

Merged
merged 2 commits into from
Aug 20, 2023
Merged

[Converters] Add toStringNoZero() function #4765

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfcf29f
[Converters] Add toStringNoZero() function
tonhuisman Aug 15, 2023
ae300f9
[Converters] Use the correct conversion
tonhuisman Aug 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/src/Helpers/StringConverter_Numerical.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,17 @@ String trimTrailingZeros(const String& value) {

}

/**
* Helper: Convert an integer to string, but return an empty string for 0, to save a little space in settings
*/
String toStringNoZero(int64_t value) {
if (value != 0) {
return toString(value, 0);
tonhuisman marked this conversation as resolved.
Show resolved Hide resolved
} else {
return EMPTY_STRING;
}
}

#if FEATURE_USE_DOUBLE_AS_ESPEASY_RULES_FLOAT_TYPE
String doubleToString(const double& value, unsigned int decimalPlaces, bool trimTrailingZeros_b) {
// This has been fixed in ESP32 code, not (yet) in ESP8266 code
Expand Down
2 changes: 2 additions & 0 deletions src/src/Helpers/StringConverter_Numerical.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ String ll2String(int64_t value,

String trimTrailingZeros(const String& value);

String toStringNoZero(int64_t value);

#if FEATURE_USE_DOUBLE_AS_ESPEASY_RULES_FLOAT_TYPE
String doubleToString(const double& value,
unsigned int decimalPlaces = 2,
Expand Down