Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More closely match Axum + Actix Leptos server implementation #10

Merged
merged 1 commit into from
Dec 1, 2024
Merged

More closely match Axum + Actix Leptos server implementation #10

merged 1 commit into from
Dec 1, 2024

Conversation

ogghead
Copy link
Contributor

@ogghead ogghead commented Nov 30, 2024 •
edited
Loading

Why is this needed?

  1. More closely match how optional params are handled in Axum and Actix server implementations
  2. Match route context implementation in Axum server

Testing

  • Tested with a Spin app using local path dependency on leptos_wasi and it still works as expected + deploys to Spin cloud

@ogghead ogghead force-pushed the match-axum-optional-param branch from 2795fd9 to ae7bc20 Compare November 30, 2024 18:42
@ogghead
Copy link
Contributor Author

ogghead commented Dec 1, 2024

@raskyld @benwis I appreciate reviews when ya'll have time!

@raskyld raskyld self-requested a review December 1, 2024 19:29
@raskyld
Copy link
Collaborator

raskyld commented Dec 1, 2024

LGTM!

@benwis
Copy link
Contributor

benwis commented Dec 1, 2024

LGTM!

@ogghead
Copy link
Contributor Author

ogghead commented Dec 1, 2024

Thank you both for the quick reviews! I don't think I have the ability to merge sadly

@benwis benwis merged commit 0ed699b into leptos-rs:main Dec 1, 2024
1 check passed
@ogghead ogghead deleted the match-axum-optional-param branch December 1, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raskyld raskyld raskyld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ogghead @raskyld @benwis