Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create filter_extinc runner #98

Open
3 tasks done
raphaelshirley opened this issue Apr 22, 2024 · 3 comments
Open
3 tasks done

Create filter_extinc runner #98

raphaelshirley opened this issue Apr 22, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@raphaelshirley
Copy link
Member

raphaelshirley commented Apr 22, 2024

filter_extinc appears to be the one command line executable which doesn't currently have Python Runner based class. Is this something we should have or otherwise have a Python based dereddening functionality?

  • I have described the purpose of the suggested change, specifying what I need the enhancement to accomplish, i.e. what problem it solves.
  • I have included any relevant links, screenshots, environment information, and data relevant to implementing the requested feature, as well as pseudocode for how I want to access the new functionality.
  • If I have ideas for how the new feature could be implemented, I have provided explanations and/or pseudocode and/or task lists for the steps.
@raphaelshirley raphaelshirley added the enhancement New feature or request label Apr 22, 2024
@raphaelshirley
Copy link
Member Author

raphaelshirley commented Apr 22, 2024

It is called from the command line like this:

filter_extinc -c COSMOS.para -FILTER FILE filter_test.dat

See p 13 of the original documentation:

https://gitlab.lam.fr/Galaxies/LEPHARE/-/blob/master/doc/LePhare_documentation.pdf?ref_type=heads

I guess we would want a python functionality along the lines of:

output = dereden(config, fluxes,efluxes, ebv)

We had a similar function in the HELP project:

https://github.com/H-E-L-P/herschelhelp_python/blob/master/herschelhelp/filters.py#L159

@raphaelshirley raphaelshirley self-assigned this Apr 22, 2024
@raphaelshirley
Copy link
Member Author

raphaelshirley commented Apr 22, 2024

On further reading I think I want a new filter_extinc.py file with:

class FilterExtinc(Runner):
    """Calculate the filter extinction values to be multiplied by E(B-V) based on config

    Parameters
    ----------
    config_file : `string`
    """

This can then have a function correct_extinction(filter,flux,flux_error,ebv)

@johannct
Copy link
Member

Sure, filter_extinc did not seem important, so I did not take care about it. Certainly like the other "executable" scripts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants