Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong center for detecting circles #29

Open
Tong-ZHAO opened this issue Mar 10, 2022 · 1 comment
Open

Wrong center for detecting circles #29

Tong-ZHAO opened this issue Mar 10, 2022 · 1 comment

Comments

@Tong-ZHAO
Copy link

When we detect circles from point sets, the resulting circle is at a wrong place. Here an example (green - inliers):
pyransac_before

After checking the code, I guess the bug comes from the line 93 in file "circle.py".
I changed it to "p_center = [p_center_x, p_center_y, P_rot[0, 2]]" then the result becomes:
pyransac_after

Could you check the code? I'm open for further discussion.

@minefantast
Copy link

same problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants