Fix failing to send broadcast intent on Android 8+ #365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes that some Badger classes (include DefaultBadger) failing to broadcast Intent on Android 8+ devices.
The cause of this issue is that
BroadcastHelper.sendIntentExplicitly()
broadcasts implicit intents instead of explicit intents.The original code uses
ResolveInfo#resolvePackageName
as the package name for the target home app.However,
ResolveInfo#resolvePackageName
does not mean the package name of the target app and is almost always null.https://developer.android.com/reference/android/content/pm/ResolveInfo#resolvePackageName
As a result, the sent intent becomes an implicit intent because package name is not set. And on Android 8 and later, broadcasting implicit intents is prohibited.
https://developer.android.com/guide/components/broadcasts#android_80
My solution is to get the package name from
ActivityInfo#packageName
.I have confirmed that DefaultBadger works fine on an Android 9 device with this fix.