Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error logging for bad SSL connections #13

Open
tomcornall opened this issue Oct 26, 2017 · 0 comments
Open

Better error logging for bad SSL connections #13

tomcornall opened this issue Oct 26, 2017 · 0 comments

Comments

@tomcornall
Copy link
Contributor

Log on a bad SSL cert looks like this ATM:

➜  zest-subscriptions lemonsync
πŸ‹  Connecting to your store (https://wholejuice.com) ... πŸ‹

/usr/local/lib/node_modules/lemonsync/bin/lemonsync.js:487
        console.details('store', 'Connected with code', response.statusCode);
                                                                ^

TypeError: Cannot read property 'statusCode' of undefined
    at Request.callback [as _callback] (/usr/local/lib/node_modules/lemonsync/bin/lemonsync.js:487:65)
    at self.callback (/usr/local/lib/node_modules/lemonsync/node_modules/request/request.js:186:22)
    at emitOne (events.js:96:13)
    at Request.emit (events.js:188:7)
    at Request.onRequestError (/usr/local/lib/node_modules/lemonsync/node_modules/request/request.js:878:8)
    at emitOne (events.js:96:13)
    at ClientRequest.emit (events.js:188:7)
    at TLSSocket.socketErrorListener (_http_client.js:309:9)
    at emitOne (events.js:96:13)
    at TLSSocket.emit (events.js:188:7)

We should make this more useful, potentially by checking SSL on the url before connecting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant