Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nx): add the ability to filter truly affected by target(s) #23

Merged

Conversation

yharaskrik
Copy link
Contributor

When running the truly affected command you can now supply a --target option that will filter affected projects by what targets they have, for example when passing --target build only projects that have a build target will be returned.

libs/core/src/types.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@EladBezalel EladBezalel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to fail, look at the get affected step in setup, it returns an error (i need to fix that)

https://github.com/lemonade-hq/traf/actions/runs/6972639752/job/18975301951#step:6:1

@yharaskrik
Copy link
Contributor Author

Seems to fail

Like when you actually run it? I added some tests to ensure its working right but maybe i need more tests. How did you test it locally so I can do the same?

@EladBezalel
Copy link
Collaborator

Sorry, panic rejected (forgot that I control merges in open source 😅)
look here
https://github.com/lemonade-hq/traf/actions/runs/6972639752/job/18975301951#step:6:1

@yharaskrik
Copy link
Contributor Author

Sorry, panic rejected (forgot that I control merges in open source 😅) look here https://github.com/lemonade-hq/traf/actions/runs/6972639752/job/18975301951#step:6:1

Ah gotcha I see! Hmm, I added to coerce to the args, but maybe that only coerces if there is a value? I probably need default: [] for --target ya?

@EladBezalel
Copy link
Collaborator

Yeah probably

@yharaskrik
Copy link
Contributor Author

Yeah probably

Should be good now.

@EladBezalel
Copy link
Collaborator

Tests are failing 😵‍💫

@ShayDavidson
Copy link
Collaborator

Let's update the docs as well 🙏

@yharaskrik
Copy link
Contributor Author

Let's update the docs as well 🙏

You got it, will do that when I have a second today

@yharaskrik
Copy link
Contributor Author

Done and done (I think thats the only doc?)

@EladBezalel EladBezalel merged commit 945eaf4 into lemonade-hq:main Nov 24, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants