-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nx): add the ability to filter truly affected by target(s) #23
feat(nx): add the ability to filter truly affected by target(s) #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to fail, look at the get affected step in setup, it returns an error (i need to fix that)
https://github.com/lemonade-hq/traf/actions/runs/6972639752/job/18975301951#step:6:1
Like when you actually run it? I added some tests to ensure its working right but maybe i need more tests. How did you test it locally so I can do the same? |
Sorry, panic rejected (forgot that I control merges in open source 😅) |
Ah gotcha I see! Hmm, I added to coerce to the args, but maybe that only coerces if there is a value? I probably need |
Yeah probably |
Should be good now. |
Tests are failing 😵💫 |
Let's update the docs as well 🙏 |
You got it, will do that when I have a second today |
Done and done (I think thats the only doc?) |
When running the truly affected command you can now supply a
--target
option that will filter affected projects by what targets they have, for example when passing--target build
only projects that have abuild
target will be returned.