Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter main route table #1

Open
wants to merge 58 commits into
base: main
Choose a base branch
from
Open

Filter main route table #1

wants to merge 58 commits into from

Conversation

leighpascoe
Copy link
Owner

@leighpascoe leighpascoe commented Mar 3, 2023 •
edited
Loading

Description

AWS does not allow you to delete main route tables, see AWS docs. This makes aws-nuke unable to delete VPC because aws-nuke thinks there is a resource that cannot be deleted that block the VPC destruction. The VPC can be deleted with the main route table still existing.

Proposed Solution
After Describing the route tables, check for any Associations where Main is true. There may be zero or many Associations, so it to find at least one. If a main route table is found, it will will not be added to the returned collection of route tables

I have tested this on VPC with just a main route table, as well as VPC's with multiple route tables.

Related Issues: rebuy-de#946 rebuy-de#785

dependabot bot and others added 30 commits March 7, 2023 13:03
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.210 to 1.44.215 (rebuy-de#954)
1e1984e 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.210 to 1.44.215.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.210...v1.44.215)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.215 to 1.44.220 (rebuy-de#959)
bd24bac 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.215 to 1.44.220.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG_PENDING.md)
- [Commits](aws/aws-sdk-go@v1.44.215...v1.44.220)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/fatih/color from 1.14.1 to 1.15.0 (rebuy-de#960)
f0e79d6 
Bumps [github.com/fatih/color](https://github.com/fatih/color) from 1.14.1 to 1.15.0.
- [Release notes](https://github.com/fatih/color/releases)
- [Commits](fatih/color@v1.14.1...v1.15.0)

---
updated-dependencies:
- dependency-name: github.com/fatih/color
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@sstoops
Add additional key types to the ListCertificates query as the default…
d7d77a2 
… only lists RSA_1024 and RSA_2048. (rebuy-de#962)
@andreadecorte
Expose HostedZone ID as property (rebuy-de#950)
dc4f7d3
@bsch150
Update MSK Cluster to include tags in the properties (rebuy-de#956)
c18155b
@andreadecorte
Expose ARN as properties for ELBs and TargetGroups for further usage (r…
e26efee 
…ebuy-de#947)

For these types of resources, the ID is the ARN, so this allows further
operations on the resource.
@der-eismann
Build with Go 1.20 (rebuy-de#963)
faa5e84
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.220 to 1.44.225 (rebuy-de#965)
696ef1b 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.220 to 1.44.225.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.220...v1.44.225)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/rebuy-de/rebuy-go-sdk/v4 from 4.4.0 to 4.5.1 (rebuy-d…
5e4600c 
…e#966)

Bumps [github.com/rebuy-de/rebuy-go-sdk/v4](https://github.com/rebuy-de/rebuy-go-sdk) from 4.4.0 to 4.5.1.
- [Release notes](https://github.com/rebuy-de/rebuy-go-sdk/releases)
- [Commits](rebuy-de/rebuy-go-sdk@v4.4.0...v4.5.1)

---
updated-dependencies:
- dependency-name: github.com/rebuy-de/rebuy-go-sdk/v4
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.225 to 1.44.230 (rebuy-de#969)
7cc4e21
@optplx
fix(CloudWatchLogsLogGroup): null pointer exception when log group di…
392093a 
…d never ingest anything (rebuy-de#928)
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.230 to 1.44.235 (rebuy-de#972)
6eea4ee 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.230 to 1.44.235.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.230...v1.44.235)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@der-eismann
Fix release action & update readme (rebuy-de#973)
7232d00 
* Fix action to update readme after release

* Stop building container images for dependabot PRs

* Update installation & compilation in readme
@github-actions @der-eismann
Update readme for v2.22.1 release (rebuy-de#974)
b99f832 
Co-authored-by: der-eismann <[email protected]>
@dependabot
Bump github.com/spf13/cobra from 1.6.1 to 1.7.0 (rebuy-de#975)
fef80c9
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.235 to 1.44.240 (rebuy-de#976)
0e03fee
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.240 to 1.44.245 (rebuy-de#979)
460b432
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.245 to 1.44.254 (rebuy-de#990)
f1483c2 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.245 to 1.44.254.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.245...v1.44.254)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump golang.org/x/sync from 0.1.0 to 0.2.0 (rebuy-de#995)
c35dd0e 
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.1.0 to 0.2.0.
- [Commits](golang/sync@v0.1.0...v0.2.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sync
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.254 to 1.44.259 (rebuy-de#994)
58736c8 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.254 to 1.44.259.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.254...v1.44.259)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@sstoops
Adding additional ECR resources by way of Cloud Control API. Also add…
e7096c0 
…ing the mapping from ECRRepository module to 'AWS::ECR::Repository'. (rebuy-de#937)
@sstoops
Add ECSTasks module (rebuy-de#988)
26889a8 
* Added an ECSTasks module to handle standalone fargate tasks which are not auto-removed by the deletion of an ECS Service.

* Removing deprecated String method. Eliminating a for-loop in the cluster query.
@sstoops
Added pagination to the IAMUser and IAMGroup modules so AWS Nuke will…
681db10 
… handle >100 of each resource type. (rebuy-de#985)
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.259 to 1.44.267 (rebuy-de#1005)
3842629
@dependabot
Bump github.com/sirupsen/logrus from 1.9.0 to 1.9.2 (rebuy-de#1007)
078c906
@dependabot
Bump github.com/stretchr/testify from 1.8.2 to 1.8.3 (rebuy-de#1006)
1f515e2 
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.2 to 1.8.3.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.8.2...v1.8.3)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@gsoria
Add SignerSigningJob module (rebuy-de#991)
02900da 
* CL-522 | Add `SignerSigningJob` module to revoke signing jobs

Signing jobs are viewable by the ListSigningJobs operation for two years after they are performed [1]
As a precaution we are updating Signing jobs statuses to revoked. This indicates that the signature is no longer valid.

[1] https://awscli.amazonaws.com/v2/documentation/api/latest/reference/signer/start-signing-job.html

Signed-off-by: Gabriela S. Soria <[email protected]>

* CL-522 | update revoking reason

Signed-off-by: Gabriela S. Soria <[email protected]>

* CL-522 | filter already revoked jobs in the `Filter` function

Signed-off-by: Gabriela S. Soria <[email protected]>

* CL-522 | include more job properties available for filters

Signed-off-by: Gabriela S. Soria <[email protected]>

---------

Signed-off-by: Gabriela S. Soria <[email protected]>
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.267 to 1.44.271 (rebuy-de#1013)
e45750a 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.267 to 1.44.271.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.267...v1.44.271)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/sirupsen/logrus from 1.9.2 to 1.9.3 (rebuy-de#1016)
d37c68e 
Bumps [github.com/sirupsen/logrus](https://github.com/sirupsen/logrus) from 1.9.2 to 1.9.3.
- [Release notes](https://github.com/sirupsen/logrus/releases)
- [Changelog](https://github.com/sirupsen/logrus/blob/master/CHANGELOG.md)
- [Commits](sirupsen/logrus@v1.9.2...v1.9.3)

---
updated-dependencies:
- dependency-name: github.com/sirupsen/logrus
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
dependabot bot and others added 28 commits June 6, 2023 13:36
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.271 to 1.44.276 (rebuy-de#1017)
2dee000 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.271 to 1.44.276.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.271...v1.44.276)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/stretchr/testify from 1.8.3 to 1.8.4 (rebuy-de#1018)
5112624 
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.3 to 1.8.4.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.8.3...v1.8.4)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.276 to 1.44.281 (rebuy-de#1026)
5cd8fc1 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.276 to 1.44.281.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.276...v1.44.281)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump golang.org/x/sync from 0.2.0 to 0.3.0 (rebuy-de#1029)
0abbe34 
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.2.0 to 0.3.0.
- [Commits](golang/sync@v0.2.0...v0.3.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sync
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.281 to 1.44.285 (rebuy-de#1030)
fb4e27a 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.281 to 1.44.285.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.281...v1.44.285)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@krzysdabro
Filter IAM roles and policy attachments related to SSO (rebuy-de#1028)
58e4627
@github-actions @der-eismann
Update readme for v2.23.0 release (rebuy-de#1032)
375dcef 
Co-authored-by: der-eismann <[email protected]>
@sstoops
Disable EC2 Instance Stop Protection (rebuy-de#986)
d7be6e0 
* First pass at implementing the logic to disable EC2 instance stop protection

* Improved comments and formatting of EC2 Instance termination/stop protection code. Also fixed the feature flag name.
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.285 to 1.44.290 (rebuy-de#1036)
902732b 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.285 to 1.44.290.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.285...v1.44.290)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@joelee
New support for Application Migration Service (MGN) resources rebuy-d…
d5c6a0d 
…e#1024 (rebuy-de#1025)

* Initial fix for issue rebuy-de#1024

* Remove buggy mgn-jobs.go

* Remove buggy mgn-jobs.go

* Add nuking of all MGN jobs:

* rebuy-de#1025 - Correction of naming convention 'Arn' to 'ARN'
@npellegrin
Add CloudFront Function (rebuy-de#1027) (rebuy-de#1031)
4e41a7f 
* Add CloudFront Function (rebuy-de#1027)

* Add missing pagination
@npellegrin
Add CloudFront Origin Access Control (rebuy-de#1019) (rebuy-de#1021)
dc13c25 
* Add CloudFront Origin Access Control (rebuy-de#1019)

* Add missing pagination and run go fmt
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.290 to 1.44.295 (rebuy-de#1038)
1ebde32 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.290 to 1.44.295.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.290...v1.44.295)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.295 to 1.44.307 (rebuy-de#1052)
6542114 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.295 to 1.44.307.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.295...v1.44.307)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.307 to 1.44.313 (rebuy-de#1061)
6ebac13 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.307 to 1.44.313.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.307...v1.44.313)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@alemuro @bjoernhaeuser
Support for TGW Attachment Peering resources (rebuy-de#996)
529f885 
Support for removing TGW Attachment Peering resources, as only VPC attachments
where supported before.

Co-authored-by: Björn Häuser <[email protected]>
@ganhuang
Enable aws-cn by setting the default partition correctly (rebuy-de#1042)
06a0dfe
@jbmchuck
kms-keys: Skip keys already in pending replica deletion state (rebuy-…
93f09c3 
…de#1046)

* kms-keys: Skip keys already in pending replica deletion state

Multi-region KMS keys enter state KeyStatePendingReplicaDeletion when
deleted, they should be filtered out in the list operation.

* Filter out PendingReplicaDeletion in the filter state rather than list state
@gdbranco @bjoernhaeuser
feat: Adding tag properties to EC2DefaultSecurityGroupRule resource (r…
8ecf7cc 
…ebuy-de#936)

Co-authored-by: Björn Häuser <[email protected]>
@vboulineau @bjoernhaeuser
Fix date format for ASG creationDate (rebuy-de#1014)
34899fb 
Co-authored-by: Björn Häuser <[email protected]>
@der-eismann
Add formatting check to GitHub Actions (rebuy-de#1063)
47fc6c7 
* Add formatting check to GitHub Actions

* Fix pre-existing formatting issues
@tbarrella @bjoernhaeuser
appconfig: add support for five resources (rebuy-de#1055)
2bef99a 
Signed-off-by: Taylor Barrella <[email protected]>
Co-authored-by: Björn Häuser <[email protected]>
@tbarrella
ecs: list all services, not just 10 (rebuy-de#1056)
90ad6c4 
Signed-off-by: Taylor Barrella <[email protected]>
@MikeSchouw @der-eismann
Adding CloudFrontOriginRequestPolicy resources. (rebuy-de#1051)
d01537a 
* Adding CloudFrontOriginRequestPolicy resources.

---------

Co-authored-by: Philipp Trulson <[email protected]>
@dependabot
Bump github.com/aws/aws-sdk-go from 1.44.313 to 1.44.318 (rebuy-de#1066)
4d7b18b 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.313 to 1.44.318.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.313...v1.44.318)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@der-eismann
Group Golang dependabot updates (rebuy-de#1070)
42a68a3 
> This is an automatically generated PR.

@rebuy-de/ FYI
@leighpascoe @bjoernhaeuser
Filter main route table
c51bb62
@leighpascoe @bjoernhaeuser
ec2-route-tables filter Main
ae6bd3c 
use `Filter` instead of custom method
@bjoernhaeuser bjoernhaeuser force-pushed the filter-main-route-tables branch from 14b4d6e to ae6bd3c Compare August 15, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.