Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger instance can't register log folder when user provide optional param #1

Open
hemulin opened this issue Jul 1, 2016 · 1 comment

Comments

@hemulin
Copy link

hemulin commented Jul 1, 2016

So,
The Logger.instance() is able to receive an optional param of log_dir.
The problem is that in the code you can find those lines:

self.__log_dir = log_dir

if self.__log_dir is None:
    self.__LOG_DIR = self.__app_dirs.logs()
AppDirs.mkdir(self.__LOG_DIR)

While I believe it should be:

self.__log_dir = log_dir

if self.__log_dir is None:
    self.__LOG_DIR = self.__app_dirs.logs()
else:
    self.__LOG_DIR = self.__log_dir
AppDirs.mkdir(self.__LOG_DIR)
@legion0
Copy link
Owner

legion0 commented Mar 23, 2018

feel free to create a pull request for this, look like a simple change :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants