-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace space in theme name with - or _ #9
Comments
We might want to follow the AUR package naming scheme :
There are a couple different ways to get there:
We could also do a combination thereof, and I suspect that's the direction we'll ultimately want to go. I will likely be a bit busy until May, so I'll add the "Help Wanted" label for now. I'll make a sample task list for anyone wanting to take on this project though (other steps might be necessary, just pitching what this might look like):
If we put the [[changes]] struct at the top of known.toml, it may be that older versions of LeftWM will be unable to parse the document, which would prevent weird name bugs. However, I think tables have to be at the end of a struct so this might not be possible. Other solutions welcome! |
With leftwm/leftwm-theme#23 merged, we'll want these configurations to be consistent. An update to themes.toml will be required for most people for LeftWM to track, I believe. Not ready to merge, blocked on leftwm/leftwm-theme#9
Based on AethanFoot/leftwm-theme-dracula-rounded#1, the folder created for themes with a space in their title will also have a space in it. This causes string splitting with the default up and down scripts as $SCRIPTPATH is not double quoted, and is not ideal in general. I feel replacing the space with an _ when creating the folder would be best practice (also removing capital letters would be nice but not needed).
The text was updated successfully, but these errors were encountered: