Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataRefTool Search Window not showing #82

Open
a533 opened this issue May 8, 2021 · 6 comments
Open

DataRefTool Search Window not showing #82

a533 opened this issue May 8, 2021 · 6 comments
Labels

Comments

@a533
Copy link

a533 commented May 8, 2021

Great app. I have found this bug:

I have a computer with two monitors. My xplane has this settings:

  • Main Monitor: Unused
  • Monitor 1: Full Screen Simulator

When I go to “Plugins” → “DataRefTool” → “Search” no windows shows. This is because the DataRefTool windows is “hidden” in the Main Monitor, which X-Plane is not using. I have to go to “Settings”→”Graphics” and select “Main Monitor” to “full screen Window”. Now the “search” window appears in the main monitor, I have to drag the setting window to the second monitor and then select “Main Monitor” back to “unused”. This has to be down every time I load X-Plane.

I think of two possible solutions:

  1. That DataRefTool checks if the “Main Monitor” is set to “unused” and draws the window in the next available monitor.
  2. That DataRefTool remembers the location of the last open window.

Thanks a lot for the excellent plugin.
A533

@leecbaker
Copy link
Owner

Hi @a533,

Thanks for the bug report. Your explanation definitely seems plausible. I don't have time to investigate more during this week or next week, but I will take a look at this eventually.

-Lee

@leecbaker leecbaker added the bug label Jul 2, 2021
@Gunduran
Copy link

Gunduran commented Sep 5, 2021

I need to come back to the topic also.

The issue is (at least reproducable on my side) whenever you have multiple monitors with different screen sizes.

My configuration in this direction from left to right) : A (1) Philips 49" monitor (5120 x 1440 max configured by default to 3840 x 1040) a (2) ASUS 28" monitor (3840 x 2160) and an older (3) ASUS 21" (1680 x 1050)

When setting up the new computer, I wanted to use monitor (2) as my Windows main monitor and the rest as required. For sure in X-Plane I want to use the monitor (1) for the main display.

Configured this way, X-Plane started, want to show datareftool==> Nothing there.

Changed to "Windowed" and the datareftool is there. Changed back to Full screen, not there.

After many tries I changed my window setting to have in Windows also monitor (1) as the main window.... And after this everything is running fine.

But I would like to go back to the original configuration (e.g. to have the taskbar fully visible on my main screen) and I looked to the developper description and tried to analyze the different situations a bit more.

I guess, the function XPLMGetScreenBoundsGlobal is not well used by the program (and also not by xchecklist by the way). Or the standard API has some issues with the screen size.

Again as a summary:

  1. If the windows main monitor is equal to the x-plane full screen monitor, everything is working fine

  2. if the windows main monitor is different than the x-plane full screen monitor, the calculation of the datareftool window is wrong, when the total XPLMGetScreenBoundsGlobal is returing a bigger size than it could be displayed (see the https://developer.x-plane.com/sdk/XPLMGetAllMonitorBoundsGlobal/ and other documentation).

Perhaps you could take a closer look to the implementation.
Best wishes,
Detlev

@dvsingletary
Copy link

I'm having the same issue since upgrading to the 2021-07-14 release from the 2020-03-23 release.

@Clamb94
Copy link

Clamb94 commented Dec 4, 2021

I have the same issue and had the same issue with my own plugin, but fixed it eventually. If you @leecbaker want, I can have a look at it here and try fixing it

Clamb94 added a commit to Clamb94/datareftool that referenced this issue Mar 31, 2022
@dvsingletary
Copy link

hey @leecbaker , any chance you can release a build that contains the fix provided by @Clamb94 ?

@leecbaker
Copy link
Owner

This change will be in the next version of DRT. Thanks for the suggestion everybody, and thanks for figuring out the code @a533 .

I will leave this issue open until the new version of DRT is released with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants