fix: Prevent submission of sign-in screen when minimum values not yet entered #4702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o fix/prevent-sign-in-submission
Nithishvb
changed the title
Nithishvb
changed the title
|
Looks good @Nithishvb, thanks for the PR, @pete-watters do you want to get this merged since you are assigned to the original issue? |
pete-watters
requested changes
Dec 15, 2023
There was a problem hiding this comment.
Thanks for this fix @Nithishvb . This fix is working well, thank you! Before I can merge I just need to clean up this PR a bit.
I still see this branch has a merge from dev included.
Can you please:
- make a branch off
devwith a single commit that makes only the change you need - commit that following our convention:
fix(wallet): ...
We ask for this as we want to keep a clean commit history
…ithishvb/extension into fix/prevent-sign-in-submission
This reverts commit 63d29ba.
This reverts commit 8dc1d22.
This reverts commit 72c3160.
This reverts commit 72c3160.
|
Closing this as work done here #4709 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4690
This PR fixes a refinement to the sign-in functionality by preventing submission of the button until minimum required values are entered.