fix: only show swaps option on mainnet #4698
Conversation
| {isMainnet && ( | ||
| <ActionButton | ||
| data-testid={HomePageSelectors.SwapBtn} | ||
| icon={<SwapIcon />} | ||
| label="Swap" | ||
| onClick={() => navigate(RouteUrls.Swap)} | ||
| /> | ||
| )} |
There was a problem hiding this comment.
We have a whenNetwork helper you can use here to avoid the equality expression on L26
|
Please reference issue in the commit msg |
edgarkhanzadian
force-pushed
the
fix/only-show-swaps-on-mainnet
branch
3 times, most recently
from
07215ab to
d799836
Compare
| label="Swap" | ||
| onClick={() => navigate(RouteUrls.Swap)} | ||
| /> | ||
| {whenNetwork(networkType)({ |
There was a problem hiding this comment.
Why would this only be based on the networkType for bitcoin?
There was a problem hiding this comment.
Perhaps my request was confusing here. whenNetwork just forwards to mainnet or testnet, but technically stacks works on chain id. As swaps is a Stacks feature, using bitcoin network types might be confusing (but works as bitcoin testnet === stacks testnet).
Alternatively, we have whenStacksChainId(); too
There was a problem hiding this comment.
Yeah, a bit confusing in code if don't know both are always the same, will that always be the case with network refactoring?
There was a problem hiding this comment.
@fbwoolf good catch! Used whenStacksChainId to check stacks testnet
edgarkhanzadian
force-pushed
the
fix/only-show-swaps-on-mainnet
branch
from
81430ca to
2f89adb
Compare
edgarkhanzadian
force-pushed
the
fix/only-show-swaps-on-mainnet
branch
from
efe1490 to
daa1627
Compare
edgarkhanzadian
force-pushed
the
fix/only-show-swaps-on-mainnet
branch
from
39e1a18 to
ce70a34
Compare
Closes #4687
swapsOnMainnet.mov