Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: swaps ui with leather-styles #4189

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Conversation

fbwoolf
Copy link
Contributor

@fbwoolf fbwoolf commented Sep 7, 2023

Try out this version of the Leather — download extension builds.

This PR refactors the swaps UI to use the new brand/design system. It also changes the summary tabs to use routes, cc @pete-watters!

Screen Shot 2023-09-07 at 12 36 02 PM Screen Shot 2023-09-07 at 12 36 10 PM Screen Shot 2023-09-07 at 1 06 16 PM

import { useFormikContext } from 'formik';
import { HStack, styled } from 'leather-styles/jsx';

import { logger } from '@shared/logger';
import { isUndefined } from '@shared/utils';

import { useAnalytics } from '@app/common/hooks/analytics/use-analytics';
// import { useExplorerLink } from '@app/common/hooks/use-explorer-link';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please delete this line now too? I know it was already like that

// import { useExplorerLink } f..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments are still being left for devs working on other parts of this feature. I believe they can be removed soon with the alex PR I'm helping out with atm.

</SwapContentLayout>
<SwapFooterLayout>
<Stack isInline spacing="base" width="100%">
<HStack gap="space.04" width="100%">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work here, I was trying to figure out how to replace <Stack isInline, I'll use <HStack 👍

Copy link
Contributor

@pete-watters pete-watters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here @fbwoolf 👍 your changes to spacing and the font styles are helping me also when refactoring away stacks/ui

@fbwoolf fbwoolf force-pushed the refactor/swaps-ui-styles branch from eed08e5 to 9bbd377 Compare September 7, 2023 18:17
@fbwoolf fbwoolf force-pushed the refactor/swaps-ui-styles branch from 9bbd377 to 2d1872c Compare September 7, 2023 18:50
@fbwoolf fbwoolf added this pull request to the merge queue Sep 7, 2023
Merged via the queue into dev with commit 4884fc5 Sep 7, 2023
28 checks passed
@fbwoolf fbwoolf deleted the refactor/swaps-ui-styles branch September 7, 2023 19:17
@mica000
Copy link

mica000 commented Sep 8, 2023

Looking good @fbwoolf!


ROW HEIGHT
What do you tink of making every row a fixed height? it will prevent changing the size according to the content. In this case, we would follow the heigh of the row with 2 lines
Screenshot 2023-09-08 at 10 32 55


LINK STYLE
What do you think of using the link style on this component?
Screenshot 2023-09-08 at 10 34 46
https://www.figma.com/file/2MLHeIeL6XPVi3Tc2DfFCr/%E2%9D%96-Leather-%E2%80%93-Design-System?type=design&node-id=5787-90549&mode=design&t=tn88fGYw436PHNQJ-4


HEADER AND SPACING AT THE TOP
I believe the header title will be solved on the Container's ticket, but wondering about the bigger spacing that seems to be on top - is this also part of that PR or it's related to the swap wrapper?
Screenshot 2023-09-08 at 10 32 36

@fbwoolf fbwoolf linked an issue Sep 11, 2023 that may be closed by this pull request
@markmhendrickson
Copy link
Collaborator

@mica000 since this PR was merged, it may be best to migrate your above comment into separate issue(s) for open tracking?

@fbwoolf
Copy link
Contributor Author

fbwoolf commented Sep 15, 2023

@mica000 since this PR was merged, it may be best to migrate your above comment into separate issue(s) for open tracking?

I can make these updates in the alex integration PR bc they are pretty minor.

@fbwoolf
Copy link
Contributor Author

fbwoolf commented Sep 15, 2023

Looking good @fbwoolf!

ROW HEIGHT What do you tink of making every row a fixed height? it will prevent changing the size according to the content. In this case, we would follow the heigh of the row with 2 lines

Yep, will do.

LINK STYLE What do you think of using the link style on this component?

Yep, I can change.

HEADER AND SPACING AT THE TOP I believe the header title will be solved on the Container's ticket, but wondering about the bigger spacing that seems to be on top - is this also part of that PR or it's related to the swap wrapper?

I think I did this bc the header title is off from where it is on the design, but the space b/w it and the label over the selector is what I am showing? If you want it moved up, np.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update swap UI w/ new design system
5 participants