-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: swaps ui with leather-styles #4189
Conversation
import { useFormikContext } from 'formik'; | ||
import { HStack, styled } from 'leather-styles/jsx'; | ||
|
||
import { logger } from '@shared/logger'; | ||
import { isUndefined } from '@shared/utils'; | ||
|
||
import { useAnalytics } from '@app/common/hooks/analytics/use-analytics'; | ||
// import { useExplorerLink } from '@app/common/hooks/use-explorer-link'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please delete this line now too? I know it was already like that
// import { useExplorerLink } f..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These comments are still being left for devs working on other parts of this feature. I believe they can be removed soon with the alex PR I'm helping out with atm.
</SwapContentLayout> | ||
<SwapFooterLayout> | ||
<Stack isInline spacing="base" width="100%"> | ||
<HStack gap="space.04" width="100%"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work here, I was trying to figure out how to replace <Stack isInline
, I'll use <HStack
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here @fbwoolf 👍 your changes to spacing
and the font styles are helping me also when refactoring away stacks/ui
eed08e5
to
9bbd377
Compare
9bbd377
to
2d1872c
Compare
Looking good @fbwoolf! ROW HEIGHT LINK STYLE HEADER AND SPACING AT THE TOP |
@mica000 since this PR was merged, it may be best to migrate your above comment into separate issue(s) for open tracking? |
I can make these updates in the alex integration PR bc they are pretty minor. |
Yep, will do.
Yep, I can change.
I think I did this bc the header title is off from where it is on the design, but the space b/w it and the label over the selector is what I am showing? If you want it moved up, np. |
This PR refactors the swaps UI to use the new brand/design system. It also changes the summary tabs to use routes, cc @pete-watters!