chore: emotionless #4178
chore: emotionless #4178
Conversation
|
Can you link an issue to your PRs or add the |
I linked the issue, thanks! Once things are ready for review I'll rebase and change the commit messages. Just working on this in phases and trying to keep work somewhat independent |
pete-watters
force-pushed
the
chore/emotionless
branch
5 times, most recently
from
55c7d17 to
1d2e578
Compare
Thanks, I know its good practice to do that, I just seemed to be making so many commits I didn't. I'll rebase this onto one commit with an issue linked. I will fix the issue in the screenshot too before merging, thanks! |
pete-watters
force-pushed
the
chore/emotionless
branch
from
1d2e578 to
902ec9a
Compare
| @@ -61,6 +61,10 @@ export const Header: React.FC<HeaderProps> = memo(props => { | |||
| justifyContent="space-between" | |||
| p="base" | |||
| minHeight={['', '80px']} | |||
There was a problem hiding this comment.
Making this change as it looked like we needed a top margin but on review of the design we haven't been changing the colour of the header in extension view:
OR this could be something that had been set by our base CSS
| @@ -135,6 +135,7 @@ const config = { | |||
| { | |||
| test: /\.(ts|tsx)$/, | |||
| exclude: /node_modules/, | |||
| // #4164 TODO investigate removing babel | |||
There was a problem hiding this comment.
@kyranjamie - I had meant to tag you here. I made a new issue for this #4199
Do you think removing babel is something you could do easily? I started to try but I was un-sure and had some difficulty with it
This PR refactors the wallet to:
We will need to QA carefully as we are removing the stacks UI base CSS but it looks mostly OK:
Kapture.2023-09-05.at.09.43.35.mp4
I updated the
test-appalso and it is missing some stuff inherited from Stacks UI (fonts etc. ) but I believe thats OK for now and we can schedule some improvements there if/when we see fit.Kapture.2023-09-05.at.09.45.25.mp4