Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profile test #5072

Closed
fbwoolf opened this issue Mar 13, 2024 · 1 comment · Fixed by #5073
Closed

Fix profile test #5072

fbwoolf opened this issue Mar 13, 2024 · 1 comment · Fixed by #5073
Assignees

Comments

@fbwoolf
Copy link
Contributor

fbwoolf commented Mar 13, 2024

This test still seems to be a problem, though it passes locally. I believe there are multiple requests happening in this test and we are only handling one of them.

In this PR I skipped the test: #5063

Assigning to myself to fix now, just wanted an issue to track it.

@fbwoolf fbwoolf self-assigned this Mar 13, 2024
@fbwoolf fbwoolf linked a pull request Mar 14, 2024 that will close this issue
@pete-watters
Copy link
Contributor

Thanks for opening this. There is another task about test reliability, check my comment here

I found that sometimes we may be over-using beforeEach to relogin etc. and that is causing us to get rate limited and then hit 429 errors.

A lot of times I saw the tests stuck, not being able to change to Testnet as it was hitting a 429 error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants