Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project: Approver UX pattern implementation #4995

Open
1 of 17 tasks
kyranjamie opened this issue Feb 28, 2024 · 0 comments
Open
1 of 17 tasks

Project: Approver UX pattern implementation #4995

kyranjamie opened this issue Feb 28, 2024 · 0 comments
Assignees
Labels
effort:large Expected to take over 1 week of integration work

Comments

@kyranjamie
Copy link
Collaborator

kyranjamie commented Feb 28, 2024

Approver UX

The Approver pattern is a reusable suite of components that guide a user through the process of approving an action

Figma link →

This issue is the home for engineering concerns relating to the Approval UX.

The approver pattern implementation is designed to be a generic flow that can be composed together to perform any approval action. It must not contain any logic specific to a single use-case. The visual designs do communicate this engineering decision.

Note

This project is for both Web and React Native. To work in parallel, we'll first make a start on the web implementation, until the project to house cross-platform components in the mono repo is complete.

Tasks

Components in Approver UX design

Interactive animated button

The latest designs have some cool interactivity states, where the button changes colour/shape during a pending flow.

image

Previously, these were normal buttons, so didn't need to be part of the approver UX. As they now consume approver ux state, the primary button might belong in the core component as Approver.Button.

This button wrapper could handle the animations, and read state from the context.

Outcomes image

These don't need wrapping into separate components, as they're just data passed to Pressable. A wrapper would only drill props and add no further value.

@kyranjamie kyranjamie added the effort:large Expected to take over 1 week of integration work label Feb 28, 2024
@kyranjamie kyranjamie added this to the Redesign approval UX milestone Feb 28, 2024
@kyranjamie kyranjamie self-assigned this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:large Expected to take over 1 week of integration work
Projects
None yet
Development

No branches or pull requests

1 participant