You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue is the home for engineering concerns relating to the Approval UX.
The approver pattern implementation is designed to be a generic flow that can be composed together to perform any approval action. It must not contain any logic specific to a single use-case. The visual designs do communicate this engineering decision.
The latest designs have some cool interactivity states, where the button changes colour/shape during a pending flow.
Previously, these were normal buttons, so didn't need to be part of the approver UX. As they now consume approver ux state, the primary button might belong in the core component as Approver.Button.
This button wrapper could handle the animations, and read state from the context.
Outcomes
These don't need wrapping into separate components, as they're just data passed to Pressable. A wrapper would only drill props and add no further value.
The text was updated successfully, but these errors were encountered:
Approver UX
Figma link →
This issue is the home for engineering concerns relating to the Approval UX.
The approver pattern implementation is designed to be a generic flow that can be composed together to perform any approval action. It must not contain any logic specific to a single use-case. The visual designs do communicate this engineering decision.
Note
This project is for both Web and React Native. To work in parallel, we'll first make a start on the web implementation, until the project to house cross-platform components in the mono repo is complete.
Tasks
Approver
feature for RN #4996AccountInfoItem
component #5008CodeViewer
component #5009HorizontalRuleSeparator component
#5010DescriptionList
design system component #5108SigningAccountDetails
feature #5107Approver
#4997Approver
#5000Approver
#4999Approver
#4998Approver
#5001Approver
#5002signPsbt
#5336signPsbt
#5337signPsbt
#5338signStacksTransaction
method #5339Components in Approver UX design
Interactive animated button
The latest designs have some cool interactivity states, where the button changes colour/shape during a pending flow.
Previously, these were normal buttons, so didn't need to be part of the approver UX. As they now consume approver ux state, the primary button might belong in the core component as
Approver.Button
.This button wrapper could handle the animations, and read state from the context.
Outcomes
These don't need wrapping into separate components, as they're just data passed to
Pressable
. A wrapper would only drill props and add no further value.The text was updated successfully, but these errors were encountered: