Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken disabled button styles #4840

Closed
kyranjamie opened this issue Jan 22, 2024 · 2 comments · Fixed by #4885
Closed

Broken disabled button styles #4840

kyranjamie opened this issue Jan 22, 2024 · 2 comments · Fixed by #4885
Assignees
Labels
area:ui UI engineering specific tasks. bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds needs:visual-improvement

Comments

@kyranjamie
Copy link
Collaborator

When in a disabled state, hover etc interactions with the button should be disabled.

Perhaps introduced in 7d75f4a ?

2024-01-22-000063.mp4
@kyranjamie kyranjamie added bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds area:ui UI engineering specific tasks. needs:visual-improvement labels Jan 22, 2024
@kyranjamie kyranjamie modified the milestone: Establish UI library Jan 22, 2024
@markmhendrickson markmhendrickson added this to the Fix urgent bugs milestone Jan 30, 2024
@kyranjamie
Copy link
Collaborator Author

@fbwoolf can you take this on?

@fbwoolf fbwoolf self-assigned this Jan 30, 2024
@fbwoolf
Copy link
Contributor

fbwoolf commented Jan 30, 2024

@fbwoolf can you take this on?

Yep, I think I fixed this on my current branch already working on the items. I will put the PR up today. Learning more abt using these recipes, sorry for bug.

fbwoolf added a commit that referenced this issue Jan 30, 2024
@fbwoolf fbwoolf linked a pull request Jan 30, 2024 that will close this issue
@fbwoolf fbwoolf removed a link to a pull request Jan 31, 2024
fbwoolf added a commit that referenced this issue Jan 31, 2024
@fbwoolf fbwoolf linked a pull request Jan 31, 2024 that will close this issue
fbwoolf added a commit that referenced this issue Jan 31, 2024
fbwoolf added a commit that referenced this issue Feb 1, 2024
kyranjamie pushed a commit that referenced this issue Feb 7, 2024
## [6.27.0](v6.26.1...v6.27.0) (2024-02-07)

### Features

* ui items, closes [#4314](#4314) ([4e6cd7d](4e6cd7d))

### Bug Fixes

* activity list items ([c01626b](c01626b))
* **analytics:** reporting empty error, closes [#4907](#4907) ([ad32854](ad32854))
* disabled button styles, closes [#4840](#4840) ([666fa37](666fa37))
* **input:** mnemonic value state ([5fa284a](5fa284a))
* ledger no request keys context ([d57f005](d57f005))
* select account overlay ([04e5d0e](04e5d0e))
* user should be able to increase fee for stacks with ledger, closes [#4503](#4503) ([47b03f6](47b03f6))

### Internal

* error helper ([a6a33a0](a6a33a0))
* flag layout stories ([a2230a6](a2230a6))
* post-release merge back ([7743f90](7743f90))
* remove unanchored microblocks, closes [#4812](#4812) ([b21decb](b21decb))
* **stories:** add stories for flags ([7b0ffab](7b0ffab))
* update monorepo tokens ([32d0caf](32d0caf))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ui UI engineering specific tasks. bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds needs:visual-improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants