Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design System: InteractiveItem #4314

Closed
6 tasks done
mica000 opened this issue Oct 3, 2023 · 15 comments · Fixed by #4881
Closed
6 tasks done

Design System: InteractiveItem #4314

mica000 opened this issue Oct 3, 2023 · 15 comments · Fixed by #4881
Assignees
Labels
area:components area:ui UI engineering specific tasks.

Comments

@mica000
Copy link

mica000 commented Oct 3, 2023

As part of the effort to consolidate our components, we will need these elements to be added to our design system.

Once added, we should replace them on the following steps:

  • Assets list
  • Activity list
  • Send
  • Receive
  • Swap asset list
  • Accounts list

image
image
image

https://www.figma.com/file/2MLHeIeL6XPVi3Tc2DfFCr/%E2%9D%96-Leather-%E2%80%93-Design-System?type=design&node-id=2081-3746&mode=design

@markmhendrickson
Copy link
Collaborator

@mica000 to update so that name and content is more generic

@mica000 mica000 changed the title Feature: Asset Selector Feature: Context menu Oct 24, 2023
@mica000 mica000 changed the title Feature: Context menu Instance: Context menu (label, copy label, section, rows) Oct 24, 2023
@mica000 mica000 added the area:ui UI engineering specific tasks. label Oct 24, 2023
@mica000
Copy link
Author

mica000 commented Oct 24, 2023

@fbwoolf @markmhendrickson ticket has been updated, please review it and let me know

@mica000 mica000 changed the title Instance: Context menu (label, copy label, section, rows) Design System Instance: Context menu (label, copy label, section, rows) Oct 24, 2023
@mica000 mica000 changed the title Design System Instance: Context menu (label, copy label, section, rows) Design System Instance: context menu (label, copy label, section, rows) Oct 24, 2023
@kyranjamie kyranjamie changed the title Design System Instance: context menu (label, copy label, section, rows) Design System Instance: content menu (label, copy label, section, rows) Nov 9, 2023
@kyranjamie
Copy link
Collaborator

To rename everywhere to content menu (we don't use context menu's anywhere in the app currently).

@mica000 mica000 changed the title Design System Instance: content menu (label, copy label, section, rows) Design System Instance: Items Dec 6, 2023
@mica000 mica000 assigned mica000 and unassigned mica000 Dec 6, 2023
@mica000 mica000 added this to the Establish UI library milestone Jan 8, 2024
@mica000 mica000 changed the title Design System Instance: Items Design System: Items Jan 8, 2024
@kyranjamie
Copy link
Collaborator

From a development perspective, this is quite a broad task to tackle as it touches content from many different components.

I wonder if "ActionItem" might be a better name as it suggests interactivity. Suggesting waiting until Storybook is merged so these can be created and reviewed in the tool.

I'm not sure what "Section" means here. Is this content for within an input? If so, I don't think we need a component for this?

@mica000
Copy link
Author

mica000 commented Jan 8, 2024

@kyranjamie thanks for the review.

Section is the equivalent of " <Select.Label>Vegetables</Select.Label>" in radix: https://www.radix-ui.com/themes/docs/components/select

@mica000
Copy link
Author

mica000 commented Jan 8, 2024

@kyranjamie in relation to the naming, if we could keep the initial root the same for all would be helpful for Figma documentation.

@kyranjamie
Copy link
Collaborator

Can we follow the same naming as Radix, and call it Select.Label?

@fbwoolf
Copy link
Contributor

fbwoolf commented Jan 8, 2024

I believe this touches the Dropdown Menu and Select components I've built already? I have built the basic list item here and the select label: #4765

EDIT: I was a bit unclear about the label naming too so can change from ...SectionLabel.

@mica000
Copy link
Author

mica000 commented Jan 9, 2024

Cool. let us know which names you will be using on the frontend so we can also update on Figma

@fabric-8
Copy link
Contributor

@kyranjamie @fbwoolf Just checking in: Did you already settle on the names?

@fbwoolf
Copy link
Contributor

fbwoolf commented Jan 16, 2024

@kyranjamie @fbwoolf Just checking in: Did you already settle on the names?

We followed what @kyranjamie mentioned ^ Select.Label and DropdownMenu.Label.

@fbwoolf
Copy link
Contributor

fbwoolf commented Jan 22, 2024

@mica000 is this ready to work on as a possible first step here? #4313

For context, Pete asked me to start with rebuilding the settings menu.

@pete-watters
Copy link
Contributor

To give context here. I'll be happy if we can even just swap out the settings menu components without doing a big re-style now if they mostly look the same.

I need to change the app Header and the settings menu is a part of that. At the moment, clicking to show the menu touches some logic in the state using jotai atoms (useShowSettingsStore).

That logic is a bit complex so I would like to put efforts into instead adding the new menu and then making things work

@mica000
Copy link
Author

mica000 commented Jan 22, 2024

@fbwoolf how are we re-naming item-interactive, item–buttons and item-address?

@kyranjamie
Copy link
Collaborator

Would decompose issue as follows:

Notes from call

  1. Create reusable styles for a kind of InteractiveRow component, that can be shared between Radix and our own uses
  2. Create reusable layout-only components to handle the repeating layout patterns
  3. Create new buttons for the item buttons

fbwoolf added a commit that referenced this issue Jan 30, 2024
@fbwoolf fbwoolf linked a pull request Jan 30, 2024 that will close this issue
fbwoolf added a commit that referenced this issue Jan 31, 2024
fbwoolf added a commit that referenced this issue Feb 1, 2024
fbwoolf added a commit that referenced this issue Feb 2, 2024
@mica000 mica000 changed the title Design System: Items Design System: InteractiveItem Feb 2, 2024
fbwoolf added a commit that referenced this issue Feb 3, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 3, 2024
kyranjamie pushed a commit that referenced this issue Feb 7, 2024
## [6.27.0](v6.26.1...v6.27.0) (2024-02-07)

### Features

* ui items, closes [#4314](#4314) ([4e6cd7d](4e6cd7d))

### Bug Fixes

* activity list items ([c01626b](c01626b))
* **analytics:** reporting empty error, closes [#4907](#4907) ([ad32854](ad32854))
* disabled button styles, closes [#4840](#4840) ([666fa37](666fa37))
* **input:** mnemonic value state ([5fa284a](5fa284a))
* ledger no request keys context ([d57f005](d57f005))
* select account overlay ([04e5d0e](04e5d0e))
* user should be able to increase fee for stacks with ledger, closes [#4503](#4503) ([47b03f6](47b03f6))

### Internal

* error helper ([a6a33a0](a6a33a0))
* flag layout stories ([a2230a6](a2230a6))
* post-release merge back ([7743f90](7743f90))
* remove unanchored microblocks, closes [#4812](#4812) ([b21decb](b21decb))
* **stories:** add stories for flags ([7b0ffab](7b0ffab))
* update monorepo tokens ([32d0caf](32d0caf))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:components area:ui UI engineering specific tasks.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants