-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design System: InteractiveItem #4314
Comments
@mica000 to update so that name and content is more generic |
@fbwoolf @markmhendrickson ticket has been updated, please review it and let me know |
To rename everywhere to content menu (we don't use context menu's anywhere in the app currently). |
From a development perspective, this is quite a broad task to tackle as it touches content from many different components. I wonder if "ActionItem" might be a better name as it suggests interactivity. Suggesting waiting until Storybook is merged so these can be created and reviewed in the tool. I'm not sure what "Section" means here. Is this content for within an input? If so, I don't think we need a component for this? |
@kyranjamie thanks for the review. Section is the equivalent of " <Select.Label>Vegetables</Select.Label>" in radix: https://www.radix-ui.com/themes/docs/components/select |
@kyranjamie in relation to the naming, if we could keep the initial root the same for all would be helpful for Figma documentation. |
Can we follow the same naming as Radix, and call it |
I believe this touches the Dropdown Menu and Select components I've built already? I have built the basic list item here and the select label: #4765 EDIT: I was a bit unclear about the label naming too so can change from |
Cool. let us know which names you will be using on the frontend so we can also update on Figma |
@kyranjamie @fbwoolf Just checking in: Did you already settle on the names? |
We followed what @kyranjamie mentioned ^ |
To give context here. I'll be happy if we can even just swap out the settings menu components without doing a big re-style now if they mostly look the same. I need to change the app That logic is a bit complex so I would like to put efforts into instead adding the new menu and then making things work |
@fbwoolf how are we re-naming |
Would decompose issue as follows: Notes from call
|
## [6.27.0](v6.26.1...v6.27.0) (2024-02-07) ### Features * ui items, closes [#4314](#4314) ([4e6cd7d](4e6cd7d)) ### Bug Fixes * activity list items ([c01626b](c01626b)) * **analytics:** reporting empty error, closes [#4907](#4907) ([ad32854](ad32854)) * disabled button styles, closes [#4840](#4840) ([666fa37](666fa37)) * **input:** mnemonic value state ([5fa284a](5fa284a)) * ledger no request keys context ([d57f005](d57f005)) * select account overlay ([04e5d0e](04e5d0e)) * user should be able to increase fee for stacks with ledger, closes [#4503](#4503) ([47b03f6](47b03f6)) ### Internal * error helper ([a6a33a0](a6a33a0)) * flag layout stories ([a2230a6](a2230a6)) * post-release merge back ([7743f90](7743f90)) * remove unanchored microblocks, closes [#4812](#4812) ([b21decb](b21decb)) * **stories:** add stories for flags ([7b0ffab](7b0ffab)) * update monorepo tokens ([32d0caf](32d0caf))
As part of the effort to consolidate our components, we will need these elements to be added to our design system.
Once added, we should replace them on the following steps:
https://www.figma.com/file/2MLHeIeL6XPVi3Tc2DfFCr/%E2%9D%96-Leather-%E2%80%93-Design-System?type=design&node-id=2081-3746&mode=design
The text was updated successfully, but these errors were encountered: