-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Design] Review, and improve, secret key input page #4120
Comments
The previous input field also worked with 15 and 18 word BIP39 inputs. Do we want to keep support for that too? Just tested 6.3.1. and 18 word seeds are still supported (I assume 15 and 21 too). |
Note that keys with fewer than 24 words will indeed work in the current version with 24 inputs, even though we could / should make their compatibility more obvious. |
FYI I have some work done to add validation to these fields in here: |
Urgent @kyranjamie @aulneau @fbwoolf Compatibility for 12-word recovery is broken. I assume it has to do something with react state management. When installing fresh and then clicking |
@marcoleder this should be fixed in version 6.11.0 of the wallet. It is not yet approved by the Chrome store but you can get it here and install from source/unzipped: https://github.com/leather-wallet/extension/releases/tag/v6.11.0 |
See bug fix for last comment about 12 word key here #4350 . Thanks for reporting @marcoleder , apologies for the any inconvenience caused |
Low priority, but we should consider how we can improve secret key input with new changes coming.
Design requirements
The text was updated successfully, but these errors were encountered: