Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show locked/stacked Stacks balances #2835

Closed
kyranjamie opened this issue Nov 10, 2022 · 8 comments · Fixed by #3605
Closed

Show locked/stacked Stacks balances #2835

kyranjamie opened this issue Nov 10, 2022 · 8 comments · Fixed by #3605
Assignees
Labels
enhancement-p2 Critical functionality needed by few users, with no clear alternatives

Comments

@kyranjamie
Copy link
Collaborator

The UI only shows available balance, and not what is stacked.

@markmhendrickson
Copy link
Collaborator

Is this the case only for Ledger-connected accounts or even software ones?

@kyranjamie
Copy link
Collaborator Author

I suppose this is not specific to Ledger. (Just happened to discover using my stacking Ledger).

@kyranjamie kyranjamie changed the title [Ledger] Show locked/stacked Stacks balances Show locked/stacked Stacks balances Nov 10, 2022
@markmhendrickson
Copy link
Collaborator

Cool, makes sense 👍

@mica000
Copy link

mica000 commented Jan 10, 2023

This design proposal includes changes the web wallet that aims to not only show the locked/stacked stacks balance but also increase the visibility of the Stacking feature.

Goal 1: Bridge the existing gap that exists on the web wallet;
Goal 2: Increase feature visibility;
Goal 3: Increase amount of Stacking users;

Web.wallet.mov

Prototype

Figma

@markmhendrickson
Copy link
Collaborator

markmhendrickson commented Jan 11, 2023

Looking good! A few notes:

  • If the user has only partially locked their balance, do we want to show both "locked" and "unlocked" sub-balances? Or just "locked" and the user has to deduce the remaining unlocked amount? I believe in the desktop wallet we show both, with the unlocked labeled "10 STX available"
  • We can create a new tab for Stacking in the wallet here (and I like the idea!), though I'm not sure we can embed the Stacking app / UX entirely there since it'll live in a separate code base for the hosted site. Perhaps we can start with a simple prompt to "get started with Stacking" that would take the user to the separate app, then enhance from there inside the wallet itself?
  • Should we perhaps show the top-level balance on the home screen in USD with the STX shown further below? We should perhaps consider that approach, placing the locked/unlocked UI under "Balances" in the STX row itself so it's specific to that asset and not others.
  • I might recommend a different icon for the Stacking tab, something that connotes earning / yield? The current graph-like icon could connote "visualize your assets over time" as easily.

Note as well that we could leverage the addition of token-specific screens for displaying detailed info about STX (and other tokens) such as locked/unlocked status. The user could click on a token listing under "Balances" and get taken to another full-view screen that's specific to the token, with various details about it for the user (and even view its specific activity history, without other token activity shown).

@markmhendrickson markmhendrickson moved this from Assigned to WIP in Hiro Wallet (DEPRECATED) Jan 17, 2023
@markmhendrickson markmhendrickson moved this from WIP to Backlog in Hiro Wallet (DEPRECATED) Feb 12, 2023
@markmhendrickson markmhendrickson added the enhancement-p2 Critical functionality needed by few users, with no clear alternatives label Feb 18, 2023
@markmhendrickson markmhendrickson added this to the PoX2 Activation milestone Feb 18, 2023
@markmhendrickson markmhendrickson moved this from Enhancements backlog to Assigned in Hiro Wallet (DEPRECATED) Apr 3, 2023
@markmhendrickson
Copy link
Collaborator

@mica000 I'm thinking that short-term until we add the new token-specific screens, we should just push a hotfix for locked vs. unlocked (because right now we show just the unlocked amount so it appears as though you've lost all the locked STX 😱)

wdyt of this simple parenthesis?

Image

@mica000
Copy link

mica000 commented Apr 6, 2023

@markmhx Seems like a good idea. Let's give it a try!

@mica000
Copy link

mica000 commented May 1, 2023

blockstack-devops pushed a commit that referenced this issue May 24, 2023
## [4.26.0](v4.25.0...v4.26.0) (2023-05-24)

### Features

* change gaia url, closes [#3678](#3678) ([baa3c4a](baa3c4a))
* show available btc balance in balances list and total balance, closes [#3685](#3685) ([c329a69](c329a69))
* show stacked balance, closes [#2835](#2835) ([80af821](80af821))

### Bug Fixes

* **analytics:** wrong api details, missing token ([db3a296](db3a296))
* live reload losing in memory key ([0803ce6](0803ce6))
* stamps query key ([647cbee](647cbee))

### Internal

* key derivation, closes [#3725](#3725) ([11f9461](11f9461))
* upgrade dev deps ([d9c9f30](d9c9f30))
* upgrade to jotai v2, other pkgs ([b3ec461](b3ec461))
@markmhendrickson markmhendrickson moved this from WIP to Released in Hiro Wallet (DEPRECATED) May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement-p2 Critical functionality needed by few users, with no clear alternatives
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants