Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Cyclic references in TaskPool #534

Open
justheuristic opened this issue Dec 12, 2022 · 0 comments
Open

[BUG] Cyclic references in TaskPool #534

justheuristic opened this issue Dec 12, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@justheuristic
Copy link
Member

Found in https://github.com/bigscience-workshop/petals/pull/150/files by @borzunov

TL;DR ModuleBackend's contain TaskPools as properties, but TaskPools refer to ModuleBackend's instance methods (e.g. self.forward)

This is harmless for run_server, but will potentially cause memory leaks if server is deleted and recreated.
@justheuristic justheuristic added the bug Something isn't working label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@justheuristic