Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing bity.com request can crash app #203

Open
TimDaub opened this issue Jul 10, 2019 · 0 comments
Open

Failing bity.com request can crash app #203

TimDaub opened this issue Jul 10, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@TimDaub
Copy link
Collaborator

TimDaub commented Jul 10, 2019

Scope

  • When "cashing out" in the Bity.js view, requests like the POST /orders can fail
  • In case where the error is caught, it was expected that the function returns in the try-catch clause
  • Apparently this doesn't happen however and so the application crashes in the next line

Screen Shot 2019-07-10 at 14 53 12

This is the line: https://github.com/leapdao/plasma-burner-wallet/blob/master/src/components/Bity.js#L152

Deliverables

  • Fix this bug and make sure app doesn't crash in bity.com cashout flow

Note

This issue might be connected to #183.

Roles

bounty gardener: @TimDaub / 10%
bounty worker: name / 75%
bounty reviewer: name / 15%

@TimDaub TimDaub added the bug Something isn't working label Jul 10, 2019
@TimDaub TimDaub added this to the Burner Current Sprint milestone Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant