Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add LLC 3D region data #153

Merged
merged 12 commits into from
Oct 24, 2024
Merged

WIP: Add LLC 3D region data #153

merged 12 commits into from
Oct 24, 2024

Conversation

jbusecke
Copy link
Contributor

@jbusecke jbusecke commented Oct 7, 2024

@dhruvbalwada starting the catalog page here. If you have time it would be great if you could check the preview.

Marking this as WIP because that bucket is currently not public (requested a change already).

@jbusecke jbusecke changed the title Add LLC 3D region data WIP: Add LLC 3D region data Oct 7, 2024
@jbusecke jbusecke marked this pull request as ready for review October 7, 2024 19:57
@jbusecke
Copy link
Contributor Author

jbusecke commented Oct 7, 2024

pre-commit.ci autofix

@jbusecke
Copy link
Contributor Author

jbusecke commented Oct 7, 2024

@andersy005 It seems like the final deployment (for previewing is not working here). Any chance you could take a look?

@andersy005
Copy link
Collaborator

@andersy005 It seems like the final deployment (for previewing is not working here). Any chance you could take a look?

@jbusecke, this is a bug and i was able to track it down and fixed it as part of

in the meantime, you can use this preview link

@jbusecke
Copy link
Contributor Author

jbusecke commented Oct 9, 2024

Thanks @andersy005! Ill wait for leap-stc/LLC4320_12h_3D-regions_feedstock#1 until moving ahead here!

@jbusecke
Copy link
Contributor Author

pre-commit.ci autofix

@jbusecke
Copy link
Contributor Author

@andersy005 I think this is ready to go. Should we wait for the preview or just go ahead and merge?

@andersy005
Copy link
Collaborator

pre-commit.ci autofix

@andersy005 andersy005 merged commit fbae016 into main Oct 24, 2024
1 check passed
@andersy005 andersy005 deleted the llc3d branch October 24, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants