Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase unit test coverage of data_utils to > 95% #24

Open
cisaacstern opened this issue Aug 18, 2023 · 0 comments
Open

Increase unit test coverage of data_utils to > 95% #24

cisaacstern opened this issue Aug 18, 2023 · 0 comments

Comments

@cisaacstern
Copy link
Contributor

cisaacstern commented Aug 18, 2023

Our current test coverage of climsim_utils.data_utils is 12%, as seen here:

https://github.com/leap-stc/ClimSim/actions/runs/5898192566/job/15998878076#step:5:43

That is not surprising because our only test is a smoke test for importability:

def test_data_utils_importable():
from climsim_utils.data_utils import data_utils

We should increase unit test coverage of data_utils to establish a benchmark of functionality before attempting any refactoring, such as proposed in #17. 95% or greater coverage would be a strong basis to shoot for.

@cisaacstern cisaacstern changed the title Increase unit test coverage of data_utils Increase unit test coverage of data_utils to > 95% Aug 18, 2023
@jerrylin96 jerrylin96 pinned this issue Aug 25, 2023
@jerrylin96 jerrylin96 unpinned this issue Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant