Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Analysis/SpecialFunctions/Integrals): simplify proof of intervalIntegrable_cpow #19877

Closed
wants to merge 1 commit into from

Conversation

dwrensha
Copy link
Member

  • have : Ioc c 0 = Ioo c 0 ∪ {(0 : ℝ)} is directly proved by (Ioo_union_right hc).symm
  • That shorter proof can then be inlined at its use in the simp in the next line.

This simplification was found by tryAtEachStep.


Open in Gitpod

Copy link

PR summary 153dff3bd5

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Dec 10, 2024
rw [← Ioo_union_Icc_eq_Ioc hc (le_refl 0), ← Icc_def]
simp_rw [← le_antisymm_iff, setOf_eq_eq_singleton']
rw [this, integrableOn_union, and_comm]; constructor
rw [← Ioo_union_right hc, integrableOn_union, and_comm]; constructor
Copy link
Member Author

@dwrensha dwrensha Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, hc has type c < 0, and Ioo_union_right applied to it has type Set.Ioo c 0 ∪ {0} = Set.Ioc c 0.

(Just noting this to show that the change I'm proposing does not introduce any defeq abuse.)

@grunweg grunweg changed the title chore(Analysis/SpecialFunctions/Integrals) simplify proof of intervalIntegrable_cpow chore(Analysis/SpecialFunctions/Integrals): simplify proof of intervalIntegrable_cpow Dec 11, 2024
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@sgouezel
Copy link
Contributor

bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Dec 11, 2024
mathlib-bors bot pushed a commit that referenced this pull request Dec 11, 2024
…lIntegrable_cpow (#19877)

* `have : Ioc c 0 = Ioo c 0 ∪ {(0 : ℝ)} `  is directly proved by `(Ioo_union_right hc).symm`
* That shorter proof can then be inlined at its use in the `simp` in the next line.

This simplification was found by [`tryAtEachStep`](https://github.com/dwrensha/tryAtEachStep).
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 11, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Analysis/SpecialFunctions/Integrals): simplify proof of intervalIntegrable_cpow [Merged by Bors] - chore(Analysis/SpecialFunctions/Integrals): simplify proof of intervalIntegrable_cpow Dec 11, 2024
@mathlib-bors mathlib-bors bot closed this Dec 11, 2024
@mathlib-bors mathlib-bors bot deleted the intervalIntegrable-cpow-tryAtEachStep branch December 11, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants