Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Topology/ContinuousMap): "ContinuousMap.evalCLM" without compactness #19876

Closed
wants to merge 3 commits into from

Conversation

loefflerd
Copy link
Collaborator

ContinuousMap.evalCLM is the evaluation-at-a-point functional on continuous-function spaces, a useful gadget to have. This is currently only defined when the domain is compact (presumably for historical reasons). This PR moves it around slightly so it is now available for any domain space.


Open in Gitpod

Copy link

github-actions bot commented Dec 10, 2024

PR summary 449eaf7fb5

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+-- evalCLM_apply
-++- evalCLM

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Dec 10, 2024
@loefflerd loefflerd requested a review from urkud December 10, 2024 17:46
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks!

I pushed an extra generalization.

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 11, 2024

✌️ loefflerd can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@loefflerd
Copy link
Collaborator Author

Thanks Eric for the review and generalisations!

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Dec 11, 2024
…ness (#19876)

`ContinuousMap.evalCLM` is the evaluation-at-a-point functional on continuous-function spaces, a useful gadget to have. This is currently only defined when the domain is compact (presumably for historical reasons). This PR moves it around slightly so it is now available for any domain space.



Co-authored-by: Eric Wieser <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 11, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Topology/ContinuousMap): "ContinuousMap.evalCLM" without compactness [Merged by Bors] - feat(Topology/ContinuousMap): "ContinuousMap.evalCLM" without compactness Dec 11, 2024
@mathlib-bors mathlib-bors bot closed this Dec 11, 2024
@mathlib-bors mathlib-bors bot deleted the DL_evalCLM branch December 11, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants