-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(Topology/ContinuousMap): "ContinuousMap.evalCLM" without compactness #19876
Conversation
PR summary 449eaf7fb5Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors d+
Thanks!
I pushed an extra generalization.
✌️ loefflerd can now approve this pull request. To approve and merge a pull request, simply reply with |
Thanks Eric for the review and generalisations! bors r+ |
…ness (#19876) `ContinuousMap.evalCLM` is the evaluation-at-a-point functional on continuous-function spaces, a useful gadget to have. This is currently only defined when the domain is compact (presumably for historical reasons). This PR moves it around slightly so it is now available for any domain space. Co-authored-by: Eric Wieser <[email protected]>
Pull request successfully merged into master. Build succeeded: |
ContinuousMap.evalCLM
is the evaluation-at-a-point functional on continuous-function spaces, a useful gadget to have. This is currently only defined when the domain is compact (presumably for historical reasons). This PR moves it around slightly so it is now available for any domain space.