Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(SetTheory/Ordinal/Arithmetic): move add_mul_limit #19805

Closed
wants to merge 2 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Dec 8, 2024

This has nothing to do with ω and can be moved much earlier in the file.

We also private the auxiliary lemma add_mul_limit_aux.


Open in Gitpod

@vihdzp vihdzp added easy < 20s of review time. See the lifecycle page for guidelines. t-set-theory Set theory labels Dec 8, 2024
Copy link

github-actions bot commented Dec 8, 2024

PR summary 449190e903

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

- add_mul_limit_aux

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
4911 -1 porting notes

Current commit 449190e903
Reference commit 7bdc7fa6e6

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).


theorem add_mul_limit {a b c : Ordinal} (ba : b + a = a) (l : IsLimit c) : (a + b) * c = a * c :=
add_mul_limit_aux ba l fun c' _ => add_mul_succ c' ba

theorem add_le_of_forall_add_lt {a b c : Ordinal} (hb : 0 < b) (h : ∀ d < b, a + d < c) :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to move this one too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took care of that lemma on a separate PR - I've merged master to reflect this.

Copy link
Contributor

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 10, 2024

✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 10, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 11, 2024
@vihdzp
Copy link
Collaborator Author

vihdzp commented Dec 11, 2024

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Dec 11, 2024
This has nothing to do with `ω` and can be moved much earlier in the file.

We also private the auxiliary lemma `add_mul_limit_aux`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 11, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(SetTheory/Ordinal/Arithmetic): move add_mul_limit [Merged by Bors] - chore(SetTheory/Ordinal/Arithmetic): move add_mul_limit Dec 11, 2024
@mathlib-bors mathlib-bors bot closed this Dec 11, 2024
@mathlib-bors mathlib-bors bot deleted the vi.add_mul_move branch December 11, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated easy < 20s of review time. See the lifecycle page for guidelines. t-set-theory Set theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants