-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Topology/Category): category of delta-generated spaces #19499
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: grunweg <[email protected]>
PR summary f15b416599Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
This PR/issue depends on:
|
Checking in from PR triage: this PR has a merge conflict. Can you merge master, please? Then this PR can be reviewed much more easily. Thanks! |
The merge conflict is fixed now. Thanks for pointing it out, I didn't notice - really unfortunate that github apparently doesn't give PR authors the option to get notified when merge confllicts occur. |
Thanks. I agree this is unfortunate. I can only think of two strategies:
|
I just took a look at your PR. I just pushed a few nits myself (to save you the extra round of suggesting them and you accepting them); feel free to revert any changes you disagree with. |
Two follow-up questions:
|
@kim-em This PR looks good to me: the proofs are reasonable, its structure matches |
Showing that they are compactly generated requires showing that they are generated not just by euclidean spaces like how I've defined them there, but also by something like the unit interval or the standard simplices. That is unfortunately tricky, because the only proof I know requires a concatenation of countably many paths - I've already written the proof up, but the details of this concatenation are unfortunately hairy, so in it I have a few sorries left. Diffeological spaces on the other hand have honestly been in reach the entire time - I just somewhat procrastinated them, both because PRing their definition feels a lot like locking in design choices that I am not yet 100% sure about, and because there are some things about them that I not not super happy with. For example, that the d-topology and quotient topology on a diffeological quotient space agree is currently only a theorem and not true by rfl, which is quite inconvenient - but changing that would require defining coinduced diffeologies only after the subspace diffeology has already been developed, which would require some restructuring across files. |
Actually thinking about it, this of course isn't true: every delta-generated space is a quotient of a disjoint union of compactly generated spaces, and so itself compactly generated. I do need the path stuff anyway to show that first-countable locally path-connected spaces are delta-generated, but at least here it isn't necessary. |
Introduces the category of delta-generated spaces and shows that it is complete, cocomplete and coreflective in the category of topological spaces.