refactor(Mathlib/Algebra/ContinuedFractions/*): change the definition of regular continuous fractions #13590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…simple continued fraction
…continued fraction
Komyyy
added
blocked-by-other-PR
Import summaryDependency changes
|
leanprover-community-mathlib4-bot
added
the
merge-conflict
Komyyy
force-pushed
the
Komyyy/RCF
branch
2 times, most recently
from
89e1fc6 to
f7ec910
Compare
leanprover-community-mathlib4-bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on: |
leanprover-community-mathlib4-bot
added
the
merge-conflict
Komyyy
removed
the
merge-conflict
leanprover-community-mathlib4-bot
added
the
merge-conflict
Komyyy
removed
the
merge-conflict
leanprover-community-bot-assistant
added
the
merge-conflict
|
❗This project is temporarily frozen, PRs are all closed for a moment(I keep the branch as it may be revived someday). Detail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In mathlib, a regular continued fraction is defined as a simple continued fraction whose partial denominators are all positive, but no matter which literature I searched, a regular continued fraction is defined as a simple continued fraction whose head term is integer and whose partial denominators are all positive naturals. Indeed, if we redefine a regular continued fraction as this way, we can get correspondence between reals and regular continued fractions which does't finish with 1, so I redefine regular continued fractions.
Zulip
This PR consists Continued fractions makes an isomorphism between irrationals and baire space
project