Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GroupTheory/GroupAction): instance MulAction (β ⧸ H) α #11212

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

shuxuezhuyi
Copy link
Collaborator

@shuxuezhuyi shuxuezhuyi commented Mar 7, 2024

We instance this naturally from MulAction β α when H is a normal subgroup and acts trivially on α.
We also instance IsometricSMul (M ⧸ N) X in this way.


Open in Gitpod

@shuxuezhuyi shuxuezhuyi added awaiting-review t-algebra Algebra (groups, rings, fields, etc) WIP Work in progress and removed awaiting-review labels Mar 7, 2024
@shuxuezhuyi shuxuezhuyi added awaiting-review and removed WIP Work in progress labels Mar 8, 2024
@YaelDillies
Copy link
Collaborator

I think @eric-wieser already did something similar.

@urkud
Copy link
Member

urkud commented Apr 18, 2024

Does it create diamonds for the action of G ⧸ H on itself? On the one hand, we have the regular action. On the other hand, we can use your instance to go from the action of G. While these two actions seem to be equal (and probably defeq), I'm not sure that they are reducibly defeq. @eric-wieser may have more insight about this.

@eric-wieser eric-wieser self-assigned this Apr 18, 2024
@urkud
Copy link
Member

urkud commented Aug 6, 2024

@eric-wieser Could you please have a look?

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 17, 2024
@grunweg
Copy link
Collaborator

grunweg commented Aug 27, 2024

@shuxuezhuyi Coming here for PR triage: thanks for your PR. It currently has a merge conflict, which means it won't show up in the review queue (and is less likely to be noticed). Can you merge the master branch, please? If you would like help with this, feel free to ask on zulip.

Copy link

github-actions bot commented Dec 3, 2024

PR summary 8eb42b45f9

Import changes exceeding 2%

% File
+2.23% Mathlib.Topology.MetricSpace.IsometricSMul

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Topology.MetricSpace.IsometricSMul 1075 1099 +24 (+2.23%)
Mathlib.GroupTheory.GroupAction.Quotient 730 733 +3 (+0.41%)
Import changes for all files
Files Import difference
Mathlib.LinearAlgebra.Alternating.DomCoprod Mathlib.Algebra.Polynomial.GroupRingAction 1
4 files Mathlib.GroupTheory.FreeGroup.NielsenSchreier Mathlib.CategoryTheory.Action Mathlib.GroupTheory.GroupAction.CardCommute Mathlib.GroupTheory.GroupAction.Quotient
3
Mathlib.Analysis.Normed.Group.AddTorsor 19
Mathlib.Topology.MetricSpace.IsometricSMul 24

Declarations diff

+ QuotientGroupAction
+ QuotientGroupAction.isometricSMul
+ _root_.AddAction.QuotientAddGroupAction
+ mulAction
+ smul

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 3, 2024
@github-actions github-actions bot added large-import Automatically added label for PRs with a significant increase in transitive imports and removed awaiting-CI labels Dec 4, 2024
@YaelDillies
Copy link
Collaborator

Can you tell us your use case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large-import Automatically added label for PRs with a significant increase in transitive imports t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants