-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(GroupTheory/GroupAction): instance MulAction (β ⧸ H) α
#11212
base: master
Are you sure you want to change the base?
Conversation
I think @eric-wieser already did something similar. |
Does it create diamonds for the action of |
@eric-wieser Could you please have a look? |
@shuxuezhuyi Coming here for PR triage: thanks for your PR. It currently has a merge conflict, which means it won't show up in the review queue (and is less likely to be noticed). Can you merge the |
PR summary 8eb42b45f9Import changes exceeding 2%
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.Topology.MetricSpace.IsometricSMul | 1075 | 1099 | +24 (+2.23%) |
Mathlib.GroupTheory.GroupAction.Quotient | 730 | 733 | +3 (+0.41%) |
Import changes for all files
Files | Import difference |
---|---|
Mathlib.LinearAlgebra.Alternating.DomCoprod Mathlib.Algebra.Polynomial.GroupRingAction |
1 |
4 filesMathlib.GroupTheory.FreeGroup.NielsenSchreier Mathlib.CategoryTheory.Action Mathlib.GroupTheory.GroupAction.CardCommute Mathlib.GroupTheory.GroupAction.Quotient |
3 |
Mathlib.Analysis.Normed.Group.AddTorsor |
19 |
Mathlib.Topology.MetricSpace.IsometricSMul |
24 |
Declarations diff
+ QuotientGroupAction
+ QuotientGroupAction.isometricSMul
+ _root_.AddAction.QuotientAddGroupAction
+ mulAction
+ smul
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
The doc-module for script/declarations_diff.sh
contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relative
value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolute
value is therelative
value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Can you tell us your use case? |
We instance this naturally from
MulAction β α
whenH
is a normal subgroup and acts trivially onα
.We also instance
IsometricSMul (M ⧸ N) X
in this way.