Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upstream Nat.binaryRec #799

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: upstream Nat.binaryRec #799

wants to merge 3 commits into from

Conversation

FR-vdash-bot
Copy link
Contributor

@FR-vdash-bot FR-vdash-bot commented May 16, 2024 •
edited
Loading

Since upstreaming to core (leanprover/lean4#3756) is still controversial, I'd like it to be upstreamed to Batteries first.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label May 16, 2024
@fgdorais fgdorais added the WIP work in progress label May 22, 2024
@FR-vdash-bot FR-vdash-bot changed the base branch from nightly-testing to main June 9, 2024 00:56
@FR-vdash-bot FR-vdash-bot marked this pull request as ready for review June 9, 2024 01:02
@FR-vdash-bot
Copy link
Contributor Author

awaiting-review

@github-actions github-actions bot added awaiting-review This PR is ready for review; the author thinks it is ready to be merged. and removed WIP work in progress labels Jun 9, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Jun 9, 2024
@FR-vdash-bot FR-vdash-bot mentioned this pull request Jun 9, 2024
Open
2 tasks
@FR-vdash-bot FR-vdash-bot mentioned this pull request Aug 6, 2024
Closed
2 tasks
@fgdorais fgdorais added the depends on another PR This is stacked on top of another Batteries PR. label Oct 1, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Oct 14, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 1, 2024
@leanprover-community-mathlib4-bot
Update Batteries branch for testing leanprover-community/batteries#799
918a68b
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting-review This PR is ready for review; the author thinks it is ready to be merged. breaks-mathlib depends on another PR This is stacked on top of another Batteries PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FR-vdash-bot @leanprover-community-bot @fgdorais @leanprover-community-mathlib4-bot