perf: inline the Decidable (Coprime _ _) instance
#1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, when faced with ``` if gcd m n = 1 then f (gcd m n) ``` the compiler will fail to perform CSE, as the `Decidable` instance is inferred as the one in this PR, which obscures the implementation from the compiler. See https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/Compiler.20inserts.20.60inBatteriesecidableCoprime.60.3F/near/444709593
eric-wieser
changed the title
Decidable (Coprime _ _) instanceDecidable (Coprime _ _) instance
github-actions
bot
added
the
awaiting-review
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 11, 2024
|
Mathlib CI status (docs):
|
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, when faced with
the compiler will fail to perform CSE and compute
gcd m ntwice, as theDecidableinstance is inferred as the one in this PR, which obscures the implementation from the compiler.See https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/Compiler.20inserts.20.60instDecidableCoprime.60.3F/near/444709593
Deleting the instance would also work.