Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Swap FluentValidation for Pure Data Annotations #247

Open
zysim opened this issue Sep 29, 2024 · 0 comments
Open

Task: Swap FluentValidation for Pure Data Annotations #247

zysim opened this issue Sep 29, 2024 · 0 comments
Labels
backlog Stuff to consider in the future

Comments

@zysim
Copy link
Collaborator

zysim commented Sep 29, 2024

We probably don't need FluentValidation for this project. Data annotations should handle our use cases already, plus we have to add extra, misleading annotations to handle null request field validation. Specifically; we need to annotate [Required(AllowEmptyStrings = true)] in order to fix what the Swagger doc says, even though we don't actually allow empty strings for that request.

Affected Functionality

  • Validation, obviously
  • Swagger doc accuracy
@zysim zysim added the backlog Stuff to consider in the future label Sep 29, 2024
@erunks erunks added this to MVP Nov 8, 2024
@github-project-automation github-project-automation bot moved this to To do in MVP Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Stuff to consider in the future
Projects
Status: To do
Development

No branches or pull requests

1 participant