Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Relations Excluded from Fetch Leaderboard Response #224

Open
zysim opened this issue Aug 11, 2024 · 1 comment
Open

Bug: Relations Excluded from Fetch Leaderboard Response #224

zysim opened this issue Aug 11, 2024 · 1 comment
Labels
backlog Stuff to consider in the future bug Something isn't working question Further information is requested

Comments

@zysim
Copy link
Collaborator

zysim commented Aug 11, 2024

We don't return the related list of Categories with the response when fetching for a leaderboard.

Step(s) to Reproduce

  1. Call GET /api/leaderboards/:id

Expected Result

  • Should return relations (i.e. categories)

Actual Outcome

  • Doesn't return relations
@zysim zysim added the bug Something isn't working label Aug 11, 2024
@TheTedder
Copy link
Contributor

That's actually not necessarily a bad thing. A lot of APIs use syntax like ?include=categories for including relations in the query. That way you can save bandwidth by not returning a potentially big list of categories and bloating the json response. Maybe we could return a list of category ids in the response by default?

@TheTedder TheTedder added the backlog Stuff to consider in the future label Aug 13, 2024
@erunks erunks added the question Further information is requested label Nov 8, 2024
@erunks erunks added this to MVP Nov 8, 2024
@github-project-automation github-project-automation bot moved this to To do in MVP Nov 8, 2024
@erunks erunks moved this from To do to Blocked in MVP Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Stuff to consider in the future bug Something isn't working question Further information is requested
Projects
Status: Blocked
Development

No branches or pull requests

3 participants