Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Incorrect Error Responses on Failed Leaderboard Creations #214

Closed
Tracked by #223
zysim opened this issue Jul 2, 2024 · 3 comments
Closed
Tracked by #223

Bug: Incorrect Error Responses on Failed Leaderboard Creations #214

zysim opened this issue Jul 2, 2024 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@zysim
Copy link
Collaborator

zysim commented Jul 2, 2024

We don't have expected error behaviour for creating Leaderboards.

Step(s) to Reproduce

  1. Create a Leaderboard with an existing name/slug
  2. Create a Leaderboard with missing/invalid fields

Expected Result

  1. Existing name/slug should 409
  2. Missing/invalids should 422

Actual Outcome

  1. Existing names/slugs 500s
  2. Missing/invalids 400s
@zysim zysim added the bug Something isn't working label Jul 2, 2024
@zysim zysim mentioned this issue Jul 2, 2024
@TheTedder
Copy link
Contributor

* Fetching users:
  
  * Fetching by ID doesn't work; request param validation outdated

Can you elaborate on this? What exactly is the issue?

@zysim
Copy link
Collaborator Author

zysim commented Jul 15, 2024

Can't fetch users by ID because the request validation failed. And it's because the validation is based on an old set of rules.

@TheTedder
Copy link
Contributor

It worked for me when I tried it, at least after making the changes in #215.

@zysim zysim changed the title Bug: Update Actions Bug: Incorrect Error Responses on Failed Leaderboard Creations Aug 11, 2024
@zysim zysim added this to the MVP milestone Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants