Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'prop-types' instead of React.PropTypes #13

Open
pintocarlos opened this issue Aug 30, 2017 · 7 comments
Open

Use 'prop-types' instead of React.PropTypes #13

pintocarlos opened this issue Aug 30, 2017 · 7 comments

Comments

@pintocarlos
Copy link

The package is breaking for me due to the deprecation of React.PropTypes from the react npm package.

PropTypes are now in 'prop-types'.
Can this be updated? @ldn0x7dc

@pintocarlos
Copy link
Author

#14 Added A PR for your review. Please review and merge at your earliest convince. Thank you. @ldn0x7dc

@Budaa
Copy link

Budaa commented Aug 31, 2017

@ldn0x7dc Can we have a merge as soon as possible, please? It's going to affect more and more people. Thanks ; )

@pintocarlos
Copy link
Author

@ldn0x7dc hey any chance you can review and merge? Thanks

@JulianKingman
Copy link

@ldn0x7dc please merge?

@rudin
Copy link

rudin commented Nov 14, 2017

Since it's taking looong time I've made a new package with prop-types fix available through:
npm i react-native-view-transformer-next

@danleveille
Copy link

@ldn0x7dc Any update on a merge?

danleveille added a commit to danleveille/react-native-view-transformer that referenced this issue Dec 16, 2020
@danleveille
Copy link

I've created a form that I'll try to keep updated: https://github.com/danleveille/react-native-view-transformer

Another package I use relies on this. I don't plan on making any improvements other than keeping it compatible with the latest React Native versions. Feel free to contribute to my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants