Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CNS-single-provider #1689

Merged
merged 67 commits into from
Oct 10, 2024
Merged

feat: CNS-single-provider #1689

merged 67 commits into from
Oct 10, 2024

Conversation

Yaroms
Copy link
Collaborator

@Yaroms Yaroms commented Sep 11, 2024

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Copy link

github-actions bot commented Sep 11, 2024

Test Results

2 225 tests  +131   2 225 ✅ +132   25m 53s ⏱️ +59s
  145 suites +  2       0 💤 ±  0 
    7 files   +  1       0 ❌  -   1 

Results for commit d60f802. ± Comparison against base commit 62e988f.

This pull request removes 7 and adds 138 tests. Note that renamed tests count towards both.
github.com/lavanet/lava/v3/x/dualstaking/keeper ‑ TestDelegateFail/bad_chainID
github.com/lavanet/lava/v3/x/dualstaking/keeper ‑ TestDualstakingUnbondStakeIsLowerThanMinSelfDelegationCausesUnstake
github.com/lavanet/lava/v3/x/dualstaking/keeper ‑ TestQueryProviderDelegatorsWithPendingDelegations
github.com/lavanet/lava/v3/x/dualstaking/keeper ‑ TestQueryWithPendingDelegations
github.com/lavanet/lava/v3/x/dualstaking/keeper ‑ TestRedelegateFail/bad_chainID
github.com/lavanet/lava/v3/x/dualstaking/keeper ‑ TestUnbondFail/bad_chainID
github.com/lavanet/lava/v3/x/pairing/keeper ‑ TestQueryDelegatorRewards/invalid_chain_ID
github.com/lavanet/lava/v3/ecosystem/cache ‑ TestCacheExpirationMultiplier
github.com/lavanet/lava/v3/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_1
github.com/lavanet/lava/v3/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_1.2
github.com/lavanet/lava/v3/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_2
github.com/lavanet/lava/v3/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_2.5
github.com/lavanet/lava/v3/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_200
github.com/lavanet/lava/v3/ecosystem/cache ‑ TestCacheFailSetWithInvalidRequestBlock
github.com/lavanet/lava/v3/ecosystem/cache ‑ TestCacheFailSetWithInvalidRequestBlock/Finalized_After_delay_No_Hash
github.com/lavanet/lava/v3/ecosystem/cache ‑ TestCacheFailSetWithInvalidRequestBlock/Finalized_After_delay_No_Hash#01
github.com/lavanet/lava/v3/ecosystem/cache ‑ TestCacheFailSetWithInvalidRequestBlock/Finalized_After_delay_With_Hash
…

♻️ This comment has been updated with latest results.

@Yaroms Yaroms requested a review from omerlavanet September 11, 2024 19:47
Copy link
Collaborator

@omerlavanet omerlavanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow this was a big one

proto/lavanet/lava/epochstorage/provider_metadata.proto Outdated Show resolved Hide resolved
x/dualstaking/keeper/delegate.go Show resolved Hide resolved
x/dualstaking/keeper/delegate.go Show resolved Hide resolved
x/dualstaking/keeper/delegate.go Outdated Show resolved Hide resolved
x/dualstaking/keeper/delegate.go Show resolved Hide resolved
x/pairing/keeper/migrations.go Show resolved Hide resolved
x/pairing/keeper/migrations.go Outdated Show resolved Hide resolved
x/pairing/keeper/migrations.go Outdated Show resolved Hide resolved
x/pairing/keeper/migrations.go Show resolved Hide resolved
x/dualstaking/keeper/migrations.go Show resolved Hide resolved
x/epochstorage/README.md Show resolved Hide resolved
x/pairing/README.md Show resolved Hide resolved
x/pairing/keeper/delegator_rewards_test.go Outdated Show resolved Hide resolved
x/pairing/keeper/single_provider_test.go Show resolved Hide resolved
x/pairing/keeper/single_provider_test.go Outdated Show resolved Hide resolved
x/pairing/keeper/single_provider_test.go Show resolved Hide resolved
x/pairing/keeper/staking.go Outdated Show resolved Hide resolved
@omerlavanet omerlavanet self-requested a review October 10, 2024 13:43
@omerlavanet omerlavanet merged commit 4394756 into main Oct 10, 2024
30 checks passed
@omerlavanet omerlavanet deleted the CNS-single-provider branch October 10, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants