Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nilaway fixes #1671

Closed
wants to merge 1 commit into from
Closed

fix: nilaway fixes #1671

wants to merge 1 commit into from

Conversation

oren-lava
Copy link
Collaborator

Description

Closes: #XXXX

In this PR I added safety checks to avoid potential nil dereference in the node's code. The potential nil dereference issues were found by Uber's nilaway tool (link).

nilaway's original reports are attached. Note, I did not fix potential errors in test code.

nilaway_reports.zip

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Copy link

github-actions bot commented Sep 3, 2024

Test Results

2 184 tests  ±0   2 184 ✅ ±0   24m 10s ⏱️ -2s
  145 suites ±0       0 💤 ±0 
    7 files   ±0       0 ❌ ±0 

Results for commit 3f06d24. ± Comparison against base commit 200972c.

@oren-lava oren-lava closed this Sep 4, 2024
@oren-lava oren-lava deleted the CNS-nilaway-fixes branch September 4, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant