Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Solver Parallelization with Loihi2 Backend #197

Merged
merged 34 commits into from
Mar 23, 2023
Merged

Enable Solver Parallelization with Loihi2 Backend #197

merged 34 commits into from
Mar 23, 2023

Conversation

GaboFGuerra
Copy link
Collaborator

@GaboFGuerra GaboFGuerra commented Mar 14, 2023 •
edited
Loading

Issue Number:

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (pyb) passes locally
  • Build tests (pyb -E unit) or (python -m unittest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@GaboFGuerra
Expose cost from CostIntegrator on the OptimizationSolver.
c9d5a13 
Signed-off-by: GaboFGuerra <[email protected]>
@GaboFGuerra
Enable cost tracking on the OptimizationSolver.
ec3c065 
Signed-off-by: GaboFGuerra <[email protected]>
@GaboFGuerra
Merge branch 'main' of https://github.com/lava-nc/lava-optimization
5d1a35c
@GaboFGuerra
Merge local and remote mains which diverged.
db392e5 
Signed-off-by: GaboFGuerra <[email protected]>
@GaboFGuerra
Remove obsolete code.
8cf27f5 
Signed-off-by: GaboFGuerra <[email protected]>
@GaboFGuerra
Solve merging issues.
cb49032 
Signed-off-by: GaboFGuerra <[email protected]>
@GaboFGuerra
Merge-in remote into local changes.
a668841 
Signed-off-by: GaboFGuerra <[email protected]>
@GaboFGuerra
Resolve import issue for ReadGate.
b4cc0c6 
Signed-off-by: GaboFGuerra <[email protected]>
@GaboFGuerra
solve linting issue
90887dc 
Signed-off-by: GaboFGuerra <[email protected]>
@GaboFGuerra
Solve linting issue.
1d8480c 
Signed-off-by: GaboFGuerra <[email protected]>
@GaboFGuerra
Split Py and C read gate models.
5981f6a 
Signed-off-by: GaboFGuerra <[email protected]>
@GaboFGuerra
Use different function for generating py and C ReadGate models.
1613fdf 
Signed-off-by: GaboFGuerra <[email protected]>
@GaboFGuerra
Change assertion to raise a ValueError instead.
51c5916 
Signed-off-by: GaboFGuerra <[email protected]>
@AlessandroPierro AlessandroPierro linked an issue Mar 16, 2023 that may be closed by this pull request
Loihi 2 backend support for parallel OptimizationSolver #171
Open
2 tasks
@GaboFGuerra GaboFGuerra marked this pull request as ready for review March 16, 2023 21:18
GaboFGuerra and others added 15 commits March 16, 2023 22:22
@GaboFGuerra
Merge branch 'main' into hp_parallel_l2
0694242
@GaboFGuerra
Solve linting inssues.
06a67f8 
Signed-off-by: GaboFGuerra <[email protected]>
@GaboFGuerra
Merge remote into local.
86ba199 
Signed-off-by: GaboFGuerra <[email protected]>
@GaboFGuerra
Reformat file.
98081e3 
Signed-off-by: GaboFGuerra <[email protected]>
@GaboFGuerra
Solve linting.
57c1d78 
Signed-off-by: GaboFGuerra <[email protected]>
@GaboFGuerra
Reformat files.
221d951 
Signed-off-by: GaboFGuerra <[email protected]>
@GaboFGuerra
Merge branch 'hp_parallel_l2' of https://github.com/lava-nc/lava-opti…
e975c09 
…mization into hp_parallel_l2
@GaboFGuerra
merge remote into local
551e717 
Signed-off-by: GaboFGuerra <[email protected]>
@GaboFGuerra
Correct test for membership.
804910b 
Signed-off-by: GaboFGuerra <[email protected]>
@GaboFGuerra
Optimize imports.
9c9cf2a 
Signed-off-by: GaboFGuerra <[email protected]>
@GaboFGuerra
Solve linting.
0ce5ca7 
Signed-off-by: GaboFGuerra <[email protected]>
@GaboFGuerra
Solve linting issue.
99efed9 
Signed-off-by: GaboFGuerra <[email protected]>
@GaboFGuerra
Update function name.
4ce3786 
Signed-off-by: GaboFGuerra <[email protected]>
@GaboFGuerra
Update function name.
61015db 
Signed-off-by: GaboFGuerra <[email protected]>
@GaboFGuerra
Add default backend to function.
058d522 
Signed-off-by: GaboFGuerra <[email protected]>
AlessandroPierro
AlessandroPierro approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@AlessandroPierro AlessandroPierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a couple of comments, feel free to implement those changes and merge.

This was a lot of hard work but it is an extremely useful feature, thank you! 🚀

src/lava/lib/optimization/solvers/generic/read_gate/models.py Show resolved Hide resolved
src/lava/lib/optimization/solvers/generic/sconfig.py Outdated Show resolved Hide resolved
@GaboFGuerra GaboFGuerra merged commit 73fc720 into main Mar 23, 2023
mgkwill pushed a commit that referenced this pull request Apr 21, 2023
Revert "Enable Solver Parallelization with Loihi2 Backend (#197)"
0413e62 
This reverts commit 73fc720.
@AlessandroPierro AlessandroPierro deleted the hp_parallel_l2 branch July 6, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlessandroPierro AlessandroPierro AlessandroPierro approved these changes

@ashishrao7 ashishrao7 Awaiting requested review from ashishrao7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loihi 2 backend support for parallel OptimizationSolver
2 participants
@GaboFGuerra @AlessandroPierro