Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Redact sensitive user details from logs in userFetcher.ts #11588

Closed
wants to merge 1 commit into from

Conversation

haresahani
Copy link

Title:
All: Fixes #11587: Redacted sensitive user details from logs in userFetcher.ts

This PR addresses issue #11587 by modifying the logging behavior in the userFetcher.ts file to ensure sensitive user information, such as email addresses and inbox details, are no longer logged. This enhances user privacy and follows best practices for logging.

Updated the logger.info statement to only log non-sensitive fields, such as userId and email.
Sensitive details like inbox_email and email are now either redacted or omitted from the logs.
This change impacts all platforms as it improves logging behavior in the core application, affecting both desktop and mobile clients.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@laurent22 laurent22 closed this Jan 6, 2025
Repository owner locked as off-topic and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Joplin cloud user details should not be printed to log file
2 participants