no-constructor-vars breaks DI

[m5rk]

I copied the tslint.json from this repository and updated my code to conform to the rules. That seemed to break my app. If I declare a provider in the ionicBootraps function:

ionicBootstrap(MyApp, [Authentication]);

but then declare its visibility like so:

export class MyClass {
  private auth: Authentication;

  constructor(auth: Authentication) {
  }

MyClass's auth is undefined. Whereas if I do this instead:

export class MyClass {
  constructor(private auth: Authentication) {
  }

It Just Works™.

[lathonez]

You need to set the class's instance of auth to the one passed in the constructor:

export class MyClass {
  private auth: Authentication;

  constructor(auth: Authentication) {
    this.auth = auth;
  }

Please reopen if this doesn't work.

[m5rk]

That works. Thank you for the quick reply.

I'm left with this question: Which is better--not manually assigning constructor parameters or not declaring parameters in the constructor?

[m5rk]

Based on the way Ionic 2 generates classes, I think they've answered that question a certain way.

[lathonez]

IMO explicit is better than implicit.

When you implicitly declare in the constructor it isn't clear that those variables are being assigned to the class (this), hence your confusion when your removed the private and found that it was no longer assigned.

It's all very subjective, but I think clearer is better.

[lathonez]

#191