Add functions to generate a similar key #361
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a reasonable approach |
|
Please squash the fix in the proper patches and force push the result |
jschlyter
force-pushed
the
generate_similar
branch
from
b4c57de to
80c3ad4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common use-case when implementing rekeying or testing is to be able to generate a similar key to an already existing one. This PR adds a
JWK.generate_similar(key)classmethod to support this, as well as aJWK.get_generate_params()to get the parameters used to generate a key. Test cases included.Perhaps there's an easier way to do this; if so please enlighten me.