Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include --netrc-file when calling curl #402

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Include --netrc-file when calling curl #402

wants to merge 1 commit into from

Conversation

sarroutbi
Copy link
Collaborator

Resolves: #401

Signed-off-by: Sergio Arroutbi [email protected]

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 31, 2023
View reviewed changes
src/pins/tang/clevis-encrypt-tang Fixed Show fixed Hide fixed
src/pins/tang/clevis-encrypt-tang Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 31, 2023
View reviewed changes
src/pins/tang/clevis-encrypt-tang Fixed Show fixed Hide fixed
src/pins/tang/clevis-encrypt-tang Fixed Show fixed Hide fixed
@sarroutbi sarroutbi force-pushed the curl_netrc_file branch 3 times, most recently from 4d17c57 to 0023816 Compare January 31, 2023 17:18
sergio-correia
sergio-correia requested changes Feb 3, 2023
View reviewed changes
Copy link
Collaborator

@sergio-correia sergio-correia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss the enhancement before diving into the code, but looking into the PR, I am not a fan of that harcoded /root/.netrc -- is this feature only intended to be used by root?

@sarroutbi
Copy link
Collaborator Author

Let's discuss the enhancement before diving into the code, but looking into the PR, I am not a fan of that harcoded /root/.netrc -- is this feature only intended to be used by root?

Well, I don't see many cases where binding is required as "non-root" user, as it normally requires access to a device. But yes, in an ideal case, this should be passed as external argument, I agree with that. I'll try to figure out how to do this, as there is no "clevis configuration file" where this could be configured

@sarroutbi
Copy link
Collaborator Author

Let's discuss the enhancement before diving into the code, but looking into the PR, I am not a fan of that harcoded /root/.netrc -- is this feature only intended to be used by root?

As this is used for encryption and decryption (also at boot time), I suggest using a configuration file under /etc. Change contemplates the possibility of this file not to exist, leaving execution intact (file can not exist, and everything will continue to work similarly)

@sarroutbi sarroutbi force-pushed the curl_netrc_file branch 2 times, most recently from b838799 to e78e752 Compare May 3, 2023 13:40
@sarroutbi sarroutbi requested a review from sergio-correia May 3, 2023 13:44
@sarroutbi sarroutbi mentioned this pull request May 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergio-correia sergio-correia Awaiting requested review from sergio-correia

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide user/password to curl when called by clevis
2 participants
@sarroutbi @sergio-correia