Duplicate test names

[Vanuan]

I'm using jasmine-reporters with jest.

Unfortunately, it doesn't detect duplicate names. So when you have multiple identical describes, multiple test results will be written to the same file. E.g.:

// jest.setup.jasmine.js
jasmine.getEnv().addReporter(
  new jasmineReporters.JUnitXmlReporter({
    // Jest runs many instances of Jasmine in parallel. Force distinct file output
    // per test to avoid collisions.
    consolidateAll: false,
    savePath: "build-artifacts/",
    filePrefix: "test-results"
  })
);

// test1.js
describe('some test', () => {
  it('should pass', () => {
    fail('error')
  })
})

// test2.js
describe('some test', () => {
  it('should pass', () => {
    // pass
  })
})

So the build would be flaky: sometimes it will fail. Sometimes it will pass.
Apparently, there's no way to detect this in jasmine reporters level, since jest can run those in different workers (node processes). Any suggestions?

[Vanuan]

Can junit report filename be generated using full path to the test file?

[Vanuan]

I've looked at modifyReportFileName and it doesn't appear that suite contains a path to the suite file.

[Vanuan]

See also jestjs/jest#4607

[Vanuan]

Jest 22 has added testPath to test case: jestjs/jest#4594

Would you consider adding that to the topLevel suite in modifyReportFileName?

[jeff-knurek]

We just experienced this issue in which our CI let a failing test pass the build because the other test with the same name passed. It also lead to the realization that about 15 other test cases weren't being evaluated properly by the CI.

[putermancer]

I'm sorry you have experienced problems. Please consider creating a pull request with appropriate improvements and I'd be happy to include those and produce a new build.